Spec URL: https://src.fedoraproject.org/rpms/dovecot-fts-xapian/pull-request/1#request_diff SRPM URL: https://clang.fedorapeople.org/dovecot-fts-xapian/dovecot-fts-xapian-1.7.14-1.fc42.src.rpm Description: This project intends to provide a straightforward, simple and maintenance free, way to configure a full text search plugin for Dovecot, leveraging the efforts by the Xapian.org team. Fedora Account System Username: clang
Copr build: https://copr.fedorainfracloud.org/coprs/build/8091727 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315641-dovecot-fts-xapian/fedora-rawhide-x86_64/08091727-dovecot-fts-xapian/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'LGPL-2.1'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/dovecot-fts-xapian Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://clang.fedorapeople.org/dovecot-fts-xapian/dovecot-fts-xapian.spec SRPM URL: https://clang.fedorapeople.org/dovecot-fts-xapian/dovecot-fts-xapian-1.7.14-1.fc42.src.rpm
Created attachment 2049551 [details] The .spec file difference from Copr build 8091727 to 8092010
Copr build: https://copr.fedorainfracloud.org/coprs/build/8092010 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315641-dovecot-fts-xapian/fedora-rawhide-x86_64/08092010-dovecot-fts-xapian/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/dovecot-fts-xapian Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/dovecot-fts-xapian See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Library General Public License, Version 2.0". 19 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/dovecot-fts- xapian/2315641-dovecot-fts-xapian/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5876 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: dovecot-fts-xapian-1.7.14-1.fc42.x86_64.rpm dovecot-fts-xapian-debuginfo-1.7.14-1.fc42.x86_64.rpm dovecot-fts-xapian-debugsource-1.7.14-1.fc42.x86_64.rpm dovecot-fts-xapian-1.7.14-1.fc42.src.rpm ======================================================== rpmlint session starts ======================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpv86mxk3r')] checks: 32, packages: 4 ================== 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 16 filtered, 0 badness; has taken 4.7 s =================== Rpmlint (debuginfo) ------------------- Checking: dovecot-fts-xapian-debuginfo-1.7.14-1.fc42.x86_64.rpm ======================================================== rpmlint session starts ======================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpmuont0ax')] checks: 32, packages: 1 =================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 1.6 s =================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 dovecot-fts-xapian.x86_64: W: unused-direct-shlib-dependency /usr/lib64/dovecot/lib21_fts_xapian_plugin.so /lib64/libicuio.so.74 dovecot-fts-xapian.x86_64: W: unused-direct-shlib-dependency /usr/lib64/dovecot/lib21_fts_xapian_plugin.so /lib64/libicudata.so.74 dovecot-fts-xapian.x86_64: W: unused-direct-shlib-dependency /usr/lib64/dovecot/lib21_fts_xapian_plugin.so /lib64/libm.so.6 dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so default_pool (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so fts_backend_default_can_lookup (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so mail_user_module_register (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so mailbox_list_mkdir_root (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so i_strdup (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so seq_range_array_add (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so mailbox_list_get_root_forced (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so i_panic (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so i_strconcat (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so t_strsplit_spaces (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so fts_mail_user_init (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so mail_storage_hooks_add (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so fts_backend_register (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so fts_backend_unregister (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so fts_mailbox_get_guid (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so mail_storage_hooks_remove (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so i_malloc (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so i_error (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so i_strdup_printf (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so buffer_append_space_unsafe (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so i_realloc (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so array_idx_set_i (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so mail_user_plugin_getenv (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so array_idx_modifiable_i (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so fts_mail_user_deinit (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so i_warning (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so buffer_create_dynamic_max (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) dovecot-fts-xapian.x86_64: W: undefined-non-weak-symbol /usr/lib64/dovecot/lib21_fts_xapian_plugin.so i_info (/usr/lib64/dovecot/lib21_fts_xapian_plugin.so) 3 packages and 0 specfiles checked; 0 errors, 31 warnings, 13 filtered, 0 badness; has taken 4.3 s Unversioned so-files -------------------- dovecot-fts-xapian: /usr/lib64/dovecot/lib21_fts_xapian_plugin.so Source checksums ---------------- https://github.com/grosjo/fts-xapian/archive/1.7.14/dovecot-fts-xapian-1.7.14.tar.gz : CHECKSUM(SHA256) this package : 257bff0cd2478be9e8f6f465dc94ceff627c0329f2837564531f4fdae15b4ab8 CHECKSUM(SHA256) upstream package : 257bff0cd2478be9e8f6f465dc94ceff627c0329f2837564531f4fdae15b4ab8 Requires -------- dovecot-fts-xapian (rpmlib, GLIBC filtered): dovecot libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libicudata.so.74()(64bit) libicui18n.so.74()(64bit) libicuio.so.74()(64bit) libicuuc.so.74()(64bit) libm.so.6()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libxapian.so.30()(64bit) rtld(GNU_HASH) dovecot-fts-xapian-debuginfo (rpmlib, GLIBC filtered): dovecot-fts-xapian-debugsource (rpmlib, GLIBC filtered): Provides -------- dovecot-fts-xapian: dovecot-fts-xapian dovecot-fts-xapian(x86-64) lib21_fts_xapian_plugin.so()(64bit) dovecot-fts-xapian-debuginfo: debuginfo(build-id) dovecot-fts-xapian-debuginfo dovecot-fts-xapian-debuginfo(x86-64) lib21_fts_xapian_plugin.so-1.7.14-1.fc42.x86_64.debug()(64bit) dovecot-fts-xapian-debugsource: dovecot-fts-xapian-debugsource dovecot-fts-xapian-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2315641 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: fonts, R, Perl, Java, PHP, Ocaml, Python, Haskell, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Upstream has a spec file https://github.com/grosjo/fts-xapian/tree/master/PACKAGES/RPM perhaps make a pull request to update it and get the license checked b) Builds on all architectures https://koji.fedoraproject.org/koji/taskinfo?taskID=124309512 c) Apart from (a), it seems ok.
Thanks, I filed https://github.com/grosjo/fts-xapian/issues/174 to address (a).
Upstream doesn't have a strong opinion about the license: https://github.com/grosjo/fts-xapian/issues/174 I'd leave it at LGPL-2.1-only then, since that's what's in the source code. It also doesn't sound like upstream is interested in updating the spec file in the repository.
Thanks for checking. Approved.
If time and expertise allow, a review of: https://bugzilla.redhat.com/show_bug.cgi?id=2317848 would be appreciated.
Thanks for the review. I'll take a look at yours now. Unretirement ticket filed at https://pagure.io/releng/issue/12442.
Landed in rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4b91dc0af8