Bug 231679 - Review Request: synce-serial - Serial connection support for Pocket PC devices
Review Request: synce-serial - Serial connection support for Pocket PC devices
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Andreas Bierfert
Fedora Package Reviews List
Depends On:
Blocks: 231680 231681
  Show dependency treegraph
Reported: 2007-03-09 17:19 EST by Aurelien Bompard
Modified: 2014-06-17 02:37 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-05-01 17:21:43 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
andreas.bierfert: fedora‑review+
wtogami: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Aurelien Bompard 2007-03-09 17:19:43 EST
Spec URL: http://gauret.free.fr/fichiers/rpms/fedora/synce/synce-serial.spec
SRPM URL: http://gauret.free.fr/fichiers/rpms/fedora/synce/synce-serial-0.9.1-1.src.rpm
Synce-serial is part of the SynCE project: http://www.synce.org
This module contains helper scripts for setting up a serial connection for use
with SynCE. They are basically wrappers around pppd:
  synce-serial-config  - Use this to select serial port and IP adresses
  synce-serial-start   - Use this to start connection
  synce-serial-abort   - Use this to abort a connection
Please read the included README.Fedora for details

SynCE is already in Fedora Extras, but in the form of a monolithic package : all the components are in the same RPM. I've splitted it, this is one of the components.
Comment 1 Aurelien Bompard 2007-04-02 05:10:17 EDT
* Mon Apr 02 2007 Aurelien Bompard <abompard@fedoraproject.org> 0.9.1-2
- fix typo in description
- make udev rules %%config(noreplace)

Comment 2 Andreas Bierfert 2007-04-27 05:44:09 EDT
Hash: SHA1

 * OK: rpmlint W: synce-serial devel-file-in-non-devel-package
/usr/bin/synce-serial-config this is not a devel file so the warning can be ignored
 * OK: package is named according to the guidelines
 * OK: spec file name matches base package name
 * OK: package meets packaging guidelines
 * OK: license
 * OK: license field matches actual license
 * OK: license is not included as own file and thus is not included in %doc
 * OK: Spec file seems to be in AE
 * OK: no obfuscated code spec
 * OK: sources match upstream:
77f8879486469118386fb7429ec5a794  synce-serial-0.9.1.tar.gz
 * OK: Builds fine on x86_64/fc6
 * OK: BR seem fine
 * OK: package has no locale support
 * OK: ldconfig is not needed 
 * OK: package is not explicitly designed to be relocatable
 * OK: does not create own dirs
 * OK: no duplicate files in file listing
 * OK: %defattr and permissions seem ok
 * OK: %clean section is present
 * OK: macros are used consistently
 * OK: content is ok
 * OK: no doc package needed
 * OK: %doc files do not affect runtime
 * OK: no header files
 * OK: no static lib
 * OK: pkgconfig is not needed
 * OK: no .so file
 * OK: no devel package
 * OK: package does not contain .la archives
 * OK: no .desktop needed
 * OK: does not own files/directories from other packages
 * OK: buildroot is rm at beginning of install
 * OK: filenames seem to be valid utf8

Package 297b755c883c6d5d98cf69559796d02a  synce-serial-0.9.1-2.src.rpm
APPROVED with the following patch:

- --- synce-serial.spec.1	2007-04-27 11:42:27.000000000 +0200
+++ synce-serial.spec	2007-04-27 11:40:48.000000000 +0200
@@ -23,17 +23,14 @@
 Please read the included README.Fedora for details
- -
 %setup -q
 cp -p %{SOURCE1} README.Fedora
- -
 make %{?_smp_mflags}
- -
@@ -42,16 +39,9 @@
 mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/udev/rules.d/
 echo 'ACTION=="add", SUBSYSTEM=="usb_device", SYSFS{idVendor}=="0bb4",
SYSFS{idProduct}=="0a06", SYMLINK+="ipaq", RUN+="%{_bindir}/synce-serial-start"'
> $RPM_BUILD_ROOT%{_sysconfdir}/udev/rules.d/60-synce.rules
- -
- -
- -%post -p /sbin/ldconfig
- -
- -%postun -p /sbin/ldconfig
- -
- -
@@ -60,8 +50,6 @@
 %config(noreplace) %{_sysconfdir}/udev/rules.d/*.rules
- -
- -
 * Mon Apr 02 2007 Aurelien Bompard <abompard@fedoraproject.org> 0.9.1-2
 - fix typo in description
Version: GnuPG v1.4.7 (GNU/Linux)

Comment 3 Aurelien Bompard 2007-04-28 01:45:59 EDT
New Package CVS Request
Package Name: synce-serial
Short Description: Serial connection support for Pocket PC devices
Owners: andreas.bierfert@lowlatency.de,gauret@free.fr
Branches: FC-6

Note You need to log in before you can comment on or make changes to this bug.