Bug 231707 - (perl-CGI-Session) Review Request: perl-CGI-Session - Persistent session data in CGI applications
Review Request: perl-CGI-Session - Persistent session data in CGI applications
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Chris Weyl
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-10 08:59 EST by Andreas Thienemann
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-23 05:38:42 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
cweyl: fedora‑review+
wtogami: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Andreas Thienemann 2007-03-10 08:59:08 EST
Spec URL: http://home.bawue.de/~ixs/perl-CGI-Session/perl-CGI-Session.spec
SRPM URL: http://home.bawue.de/~ixs/perl-CGI-Session/perl-CGI-Session-4.20-1.src.rpm
Description:
CGI-Session is a Perl5 library that provides an easy, reliable and modular
session management system across HTTP requests. Persistency is a key
feature for such applications as shopping carts, login/authentication
routines, and application that need to carry data across HTTP requests.
CGI::Session does that and many more.
Comment 1 Chris Weyl 2007-03-17 00:05:08 EDT
Replace %fedora conditional with a buildrequires: perl(ExtUtils::MakeMaker)
and make rpmlint happy :) and I'll approve. 


+ source files match upstream:
 34740f5b944d42760816288f727f98fb  CGI-Session-4.20.tar.gz
 34740f5b944d42760816288f727f98fb  ../CGI-Session-4.20.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.  License text not included upstream.
+ latest version is being packaged.
O BuildRequires are proper. (needs a br on perl(ExtUtils::MakeMaker))
+ %clean is present.
+ package installs properly
X rpmlint is (almost) silent:
[build@zeus perl-CGI-Session]$ rpmlint perl-CGI-Session-4.20-1.fc6.src.rpm 
W: perl-CGI-Session mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12)
+ final provides and requires are sane:
 == provides
 perl(CGI::Session)  
 perl(CGI::Session::Driver)  
 perl(CGI::Session::Driver::DBI)  
 perl(CGI::Session::Driver::db_file) = 4.20
 perl(CGI::Session::Driver::file)  
 perl(CGI::Session::Driver::mysql)  
 perl(CGI::Session::Driver::postgresql)  
 perl(CGI::Session::Driver::sqlite)  
 perl(CGI::Session::ErrorHandler)  
 perl(CGI::Session::ID::incr)  
 perl(CGI::Session::ID::md5)  
 perl(CGI::Session::ID::static)  
 perl(CGI::Session::Serialize::default)  
 perl(CGI::Session::Serialize::freezethaw)  
 perl(CGI::Session::Serialize::json)  
 perl(CGI::Session::Serialize::storable)  
 perl(CGI::Session::Serialize::yaml)  
 perl(CGI::Session::Test::Default)  
 perl(CGI::Session::Tutorial)  
 perl(OverloadedObjectClass)  
 perl(SimpleObjectClass)  
 perl-CGI-Session = 4.20-1.fc6
 == requires
 perl(:MODULE_COMPAT_5.8.8)  
 perl(CGI::Session::Driver)  
 perl(CGI::Session::Driver::DBI)  
 perl(CGI::Session::ErrorHandler)  
 perl(Carp)  
 perl(Class::Struct)  
 perl(DBD::Pg)  
 perl(DBI)  
 perl(DB_File)  
 perl(Data::Dumper)  
 perl(Digest::MD5)  
 perl(Fcntl)  
 perl(File::Basename)  
 perl(File::Spec)  
 perl(FreezeThaw)  
 perl(Safe)  
 perl(Scalar::Util)  
 perl(Storable)  
 perl(Test::More)  
 perl(base)  
 perl(overload)  
 perl(strict)  
 perl(vars)  
+ %check is present and all tests pass:
All tests successful, 7 tests skipped.
Files=46, Tests=1295, 47 wallclock secs ( 9.29 cusr +  1.88 csys = 11.17 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
Comment 2 Andreas Thienemann 2007-03-17 05:57:06 EDT
http://home.bawue.de/~ixs/perl-CGI-Session/perl-CGI-Session-4.20-2.src.rpm

New SRPM & spec
Comment 3 Chris Weyl 2007-03-17 12:17:24 EDT
APPROVED
Comment 4 Andreas Thienemann 2007-03-17 12:34:44 EDT
New Package CVS Request
=======================
Package Name: perl-CGI-Session
Short Description: Persistent session data in CGI applications
Owners: andreas@bawue.net
Branches: FC-5, FC-6, devel
InitialCC: fedora-perl-devel-list@redhat.com
Comment 5 Andreas Thienemann 2007-03-23 05:38:42 EDT
Thanks for the review, package has been built for FC-5, FC-6 and rawhide.

Note You need to log in before you can comment on or make changes to this bug.