Bug 232070 - Review Request: hawknl - Game oriented network library
Review Request: hawknl - Game oriented network library
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Aurelien Bompard
Fedora Package Reviews List
:
Depends On:
Blocks: 232071
  Show dependency treegraph
 
Reported: 2007-03-13 16:03 EDT by Hans de Goede
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-15 08:00:18 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
gauret: fedora‑review+
petersen: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Hans de Goede 2007-03-13 16:03:04 EDT
Spec URL: http://people.atrpms.net/~hdegoede/hawknl.spec
SRPM URL: http://people.atrpms.net/~hdegoede/hawknl-1.68-1.fc7.src.rpm
Description:
HawkNL is a free, open source, game oriented network API released under the 
GNU LGPL. HawkNL (NL) is a fairly low level API, a wrapper over Berkeley/Unix
Sockets and Winsock. But NL also provides other features.
Comment 1 Aurelien Bompard 2007-03-15 02:50:53 EDT
Review for release 1.fc6:
* RPM name is OK
* Source HawkNL168src.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint looks OK
* File lists look OK
* Works fine
(32 checks have been run)

Details:
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
You can add that before or after importing.


Comment 2 Hans de Goede 2007-03-15 03:55:55 EDT
(In reply to comment #1)
> * Missing SMP flags. If it doesn't build with it, please add a comment
>   (wiki: PackagingGuidelines#parallelmake)

Good catch, I'll add that before importing.

New Package CVS Request
=======================
Package Name:      hawknl
Short Description: Game oriented network library
Owners:            j.w.r.degoede@hhs.nl
Branches:          FC-6 devel 
InitialCC:         <empty>

Comment 3 Jens Petersen 2007-03-15 04:10:41 EDT
done
Comment 4 Hans de Goede 2007-03-15 08:00:18 EDT
Thanks for the review!

Imported and build, closing.

Note You need to log in before you can comment on or make changes to this bug.