Bug 232355 - Review Request: firmware-tools - Scripts and tools to manage firmware and BIOS updates
Review Request: firmware-tools - Scripts and tools to manage firmware and BIO...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matt Domsch
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-14 18:00 EDT by Michael E Brown
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-16 10:11:06 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
matt_domsch: fedora‑review+
jwboyer: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Michael E Brown 2007-03-14 18:00:16 EDT
Spec URL: http://linux.dell.com/libsmbios/download/firmware-tools/firmware-tools-1.2.0/firmware-tools.spec

SRPM URL: 
http://linux.dell.com/libsmbios/download/firmware-tools/firmware-tools-1.2.0/firmware-tools-1.2.0-1.src.rpm

Description:

The firmware-tools project provides the following toolset:
  -- BIOS and Firmware inventory: provide a list of firmware versions present on a hardware system. Uses a plugin system so OEM can write plugins to get versions from their specific firmware

  -- BIOS and Firmware upgrade: given a BIOS or Firmware update, apply it to the system. Uses a plugin system so OEM can write plugins to update their specific hardware

  -- Package bootstrap: method to detect which packages might be necessary to complete a full inventory and update for hardware present on the system. Uses a plugin system so OEM can write plugins to get versions from their specific hardware.

The firmware-tools project provides tools to inventory hardware and a plugin
architecture so that different OEM vendors can provide different inventory
components. It is intended to tie to the package system to enable seamless
installation of updated firmware via your package manager, as well as provide
a framework for BIOS and firmware updates.
Comment 1 Michael E Brown 2007-03-14 18:02:16 EDT
Used wrong buzilla account to log this... should be mebrown@michaels-house.net,
as that is my FAS account.
Comment 2 Michael E Brown 2007-03-15 00:58:36 EDT
Posted small update:
http://linux.dell.com/libsmbios/download/firmware-tools/firmware-tools-1.2.1/firmware-tools.spec
http://linux.dell.com/libsmbios/download/firmware-tools/firmware-tools-1.2.1/firmware-tools-1.2.1-1.src.rpm

%changelog
* Wed Mar 14 2007 Michael E Brown <michael_e_brown at dell.com> - 1.2.0-1
- create and own %{_sysconfdir}/firmware/firmware.d/ for plugins.
Comment 3 Rudolf Kastl 2007-03-15 09:43:00 EDT
/usr/share/firmware should probably be owned by the package because its
configured as storage dir in the default conf file.
Comment 5 Rudolf Kastl 2007-03-15 10:34:39 EDT
again a small issue (this is not a package review though) that is pretty easy to
fix in the %files section:

warning: File listed twice: /etc/firmware/firmware.conf
warning: File listed twice: /etc/firmware/firmware.d
Comment 6 Michael E Brown 2007-03-15 11:05:39 EDT
doh. Fixed in 1.2.3. It is a one line fix (remove entry from %files). I wont
post a fix for this by itself.
Comment 8 Matt Domsch 2007-03-15 18:02:28 EDT
$ rpmlint *rpm
W: firmware-tools strange-permission firmware-tools.spec 0600
 - false positive, CVS won't have this of course


MUSTs:
* passes naming guidelines
* spec file name correct
* packaging guidelines:
  * name ok
  * license OK
  * nothing prebuilt
  * files FHS
  * passes rpmlint
  * has changelog
  * no packager tag
  * no vendor tag
  * has license tag
  * summary doesn't end in .
  * no PreReq
  * Source0 needs fixing!!!
  * buildroot OK
  * requires ok
  * summary and description ok
  * encoding UTF8
  * documentation ok
  * optflags unneeded
  * debuginfo not disabled
  * no static libs
  * no system library dupes
  * no rpath
  * config is noreplace, not in /usr
  * no initscripts
  * no desktop file needed
  * uses macros not hard-coded dirs
  * consistent use of macros
  * no locales
  * no copying of files in setup
  * no parallel make as no make
  * no scriptlets
  * no conditional deps
  * builds in mock with separate user
  * not relocatable
  * is code, not content
  * files and dirs owned properly
  * not a web app

* License is GPL/OSL dual, ok
* License tag OK
* licenses in %doc
* spec in english
* spec legible
* sources match upstream
* compiles and builds on all arches (it's noarch)
* BuildRequires correct
* No locales to care about
* no shared libs
* not relocatable
* owns the dirs it creates
* no dup files
* defattr present
* file permissions ok
* consistent use of macros
* contains code
* no need for separate -doc
* %doc files present but not critical for runtime
* no headers
* no static libs
* no .pc files
* no shared libs
* no -devel
* no libtool archives
* no desktop file needed
* directory ownership ok

SHOULDs:
* licenses present upstream
* no translations - ok
* builds in mock
* builds into noarch
* runs fine
* no scriptlets
* no subpackages
* no .pc files
* no file deps


APPROVED.
Comment 9 Michael E Brown 2007-03-15 18:40:13 EDT
New Package CVS Request
=======================
Package Name: firmware-tools
Short Description: Scripts and tools to manage firmware and BIOS updates
Owners: mebrown@michaels-house.net,matt_domsch@dell.com
Branches: FC-6 EPEL-4 EPEL-5
InitialCC:
Comment 10 Josh Boyer 2007-03-15 20:47:56 EDT
Done.  For future reference, the EPEL branches are simply EL-4 and EL-5

Note You need to log in before you can comment on or make changes to this bug.