Bug 232417 - Review Request: firmware-addon-dell - A firmware-tools plugin to handle BIOS/Firmware for Dell systems
Review Request: firmware-addon-dell - A firmware-tools plugin to handle BIOS/...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matt Domsch
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-15 09:11 EDT by Michael E Brown
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-16 10:11:55 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
matt_domsch: fedora‑review+
jwboyer: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Michael E Brown 2007-03-15 09:11:38 EDT
Spec URL: http://linux.dell.com/libsmbios/download/firmware-addon-dell/firmware-addon-dell-1.2.1/firmware-addon-dell.spec

SRPM URL: http://linux.dell.com/libsmbios/download/firmware-addon-dell/firmware-addon-dell-1.2.1/firmware-addon-dell-1.2.1-1.src.rpm

Description: 

The firmware-addon-dell package provides plugins to firmware-tools which enable
BIOS updates for Dell system, plus pulls in standard inventory modules
applicable to most Dell systems.

Note: rpmlint gives one bogus error: 
$ rpmlint firmware-addon-dell-1.2.1-1.noarch.rpm 
E: firmware-addon-dell explicit-lib-dependency libsmbios-bin

This is not an error because it is not an explicit lib dependency. The libsmbios-bin package has no libraries, just executables, which this plugin calls. The automatic dep generator does not find this dependency.
Comment 1 Rudolf Kastl 2007-03-15 10:31:47 EDT
heyyas and thanks for fixing the unowned dir issue on the firmware tools package
that fast. that motivated me to also look at the dell plugin so here it goes:

/usr/share/firmware/dell should probably be owned by this package
Comment 2 Michael E Brown 2007-03-15 10:57:55 EDT
There is no dell-specific /usr/share/firmware subdirectory.
Comment 3 Rudolf Kastl 2007-03-15 11:00:44 EDT
you are right but theres 

/usr/share/firmware/bios which is specified in

storage_subdir=bios

the question is just if its general it probably should be owned by
firmware-tools but whats a fact is that it most probably should be owned by a
package.

sorry for the bogus report above. happens... ;)
Comment 4 Michael E Brown 2007-03-15 11:08:38 EDT
problem is that firmware-addon-ibm may also want to put stuff in
/usr/share/firmware/bios/ (example only, I can hope, though. :)
Comment 6 Matt Domsch 2007-03-15 18:04:28 EDT
rpmlint results
E: firmware-addon-dell explicit-lib-dependency libsmbios-bin
 - false positive commented in spec file

W: firmware-addon-dell strange-permission firmware-addon-dell.spec 0600
 - another false positive - CVS won't have this problem of course


MUSTs:
* passes naming guidelines
* spec file name correct
* packaging guidelines:
  * name ok
  * license OK
  * nothing prebuilt
  * files FHS
  * passes rpmlint
  * has changelog
  * no packager tag
  * no vendor tag
  * has license tag
  * summary doesn't end in .
  * no PreReq
  * Source0 needs fixing!!!
  * buildroot OK
  * requires ok
  * summary and description ok
  * encoding UTF8
  * documentation ok
  * optflags unneeded
  * debuginfo not disabled
  * no static libs
  * no system library dupes
  * no rpath
  * config is noreplace, not in /usr
  * no initscripts
  * no desktop file needed
  * uses macros not hard-coded dirs
  * consistent use of macros
  * no locales
  * no copying of files in setup
  * no parallel make as no make
  * no scriptlets
  * no conditional deps
  * builds in mock with separate user
  * not relocatable
  * is code, not content
  * files and dirs owned properly
  * not a web app

* License is GPL/OSL dual, ok
* License tag OK
* licenses in %doc
* spec in english
* spec legible
* sources match upstream
* compiles and builds on all arches (it's noarch)
* BuildRequires correct
* No locales to care about
* no shared libs
* not relocatable
* owns the dirs it creates
* no dup files
* defattr present
* file permissions ok
* consistent use of macros
* contains code
* no need for separate -doc
* %doc files present but not critical for runtime
* no headers
* no static libs
* no .pc files
* no shared libs
* no -devel
* no libtool archives
* no desktop file needed
* directory ownership ok

SHOULDs:
* licenses present upstream
* no translations - ok
* builds in mock
* builds into noarch
* runs fine
* no scriptlets
* no subpackages
* no .pc files
* no file deps


APPROVED.
Comment 7 Michael E Brown 2007-03-15 18:41:30 EDT
New Package CVS Request
=======================
Package Name: firmware-addon-dell
Short Description: A firmware-tools plugin to handle BIOS/Firmware for Dell systems
Owners: mebrown@michaels-house.net,matt_domsch@dell.com
Branches: FC-6 EPEL-4 EPEL-5
InitialCC:

Note You need to log in before you can comment on or make changes to this bug.