Bug 23272 - ntop's webinterface doesn't work correcty.
ntop's webinterface doesn't work correcty.
Status: CLOSED WONTFIX
Product: Red Hat Powertools
Classification: Retired
Component: ntop (Show other bugs)
7.0
i386 Linux
medium Severity medium
: ---
: ---
Assigned To: Ngo Than
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2001-01-04 03:02 EST by Need Real Name
Modified: 2008-05-01 11:37 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2001-01-04 03:02:29 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Need Real Name 2001-01-04 03:02:26 EST
ntop's webinterface can't handle modify user requests among other things.
http.c:434 says something like this:
  if(questionMark == NULL)
    sortedColumn = 0;
  else {
    if((questionMark[0] == '?') && (strlen(questionMark) > 3)) {
      questionMark[0] = 0;
      questionMark = strchr(&questionMark[1], '=');
      sortedColumn = 1+abs(atoi(&questionMark[1]));

atoi() doens't like to be called with a (NULL+1) pointer.

I changed this to:
  if(questionMark == NULL)
    sortedColumn = 0;
  else {
    if((questionMark[0] == '?') && (strlen(questionMark) > 3)) {
      char *x;
      x = strchr(&questionMark[1], '=');
      if(x) {
        questionMark = x;
        questionMark[0] = '\0';
        sortedColumn = 1+abs(atoi(&questionMark[1]));
      }

and now everything legal works.
Comment 1 Ngo Than 2001-01-04 07:00:51 EST
ntop-1.3.2-2 in rawhide is not effected from this bug.

Note You need to log in before you can comment on or make changes to this bug.