SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-Carp-0.01-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-Carp.spec Description: This module exports four functions, of which two override the standard die() and warn() functions, and two which allow for extended error reporting. When called, these functions display a user-friendly message dialog window.
mock build went fine but got make test failed PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/use....Gtk-WARNING **: cannot open display: at /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/Gtk2.pm line 63. dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 1 Failed 1/1 tests, 0.00% okay Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/use.t 1 256 1 2 200.00% 1 Failed 1/1 test scripts, 0.00% okay. 1/1 subtests failed, 0.00% okay. make: *** [test_dynamic] Error 1 Am I missing something??
Nope, nothing missing -- make test fails here as mock (correctly) runs with $DISPLAY unset. New spec/srpm to follow.
SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-Carp-0.01-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Ex-Carp.spec Description: This module exports four functions, of which two override the standard die() and warn() functions, and two which allow for extended error reporting. When called, these functions display a user-friendly message dialog window. New spec/srpm posted.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url a9e6de1c2e54c504d19b6b0f5faa3f5b Gtk2-Ex-Carp-0.01.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test results nothing. + Provides: perl(Gtk2::Ex::Carp) = 0.01 perl(Gtk2::Ex::Carp::ExtendedErrorDialog) APPROVED.
New Package CVS Request ======================= Package Name: perl-Gtk2-Ex-Carp Short Description: GTK+ friendly die() and warn() functions Owners: cweyl.edu Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list
Branched, imported, building. Thanks for the review! :)