Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/mecab-java.spec SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/mecab-java-0.95-1.fc7.src.rpm Mock build log on FC-devel i386: ttp://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/LOGS/MOCK-mecab-java.log Description: Java binding for MeCab.
mecab is updated to 0.96. http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/Fedora/development/SPECS/mecab-java.spec http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/Fedora/development/SRPMS/mecab-java-0.96-1.fc8.src.rpm http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/Fedora/development/LOGS/MOCK-mecab-java.log
Starting review...
Created attachment 157174 [details] mock: build log on x86_64 Failed to build on test.java from x86_64 arch.
Would you attach the test.java and test.java.orig on mockbuild x86_64?
Created attachment 157191 [details] mecab-java: test.java file containing encoding expression It seem that some BR could be missing cause i haven't the necessary font to print some character and its failed to recognize them. test.java:24: error: Unrecognized character for encoding 'ANSI_X3.4-1968'. System.out.println (tagger.parse ("太郎は二郎にこの本を渡した."));
Created attachment 157192 [details] test.java.orig
Well, while I doubt this is related to font issue because mockbuild sets the LANG value to C and even if I set LANG and LC_ALL to C the compilation of test.java succeeds for me, currently I don't know the correct solution. As this is a test java script for now I nuked the test. http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/Fedora/development/SPECS/mecab-java.spec http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/Fedora/development/SRPMS/mecab-java-0.96-1.fc8.src.rpm --------------------------------------------------- * Sun Jun 17 2007 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.96-2 - Nuke test for now
The correct one: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/Fedora/development/SRPMS/mecab-java-0.96-2.fc8.src.rpm
It got me some strange character now but the build pass fine. I'll work around to find how it could be fix. For now, mock working...
[ OK ] Tested Arch with Mock: x86_64 (F-7 and FC-6) [ OK ] Package is named according to the Package Naming Guidelines. [ OK ] Spec file name match the base package %{name} [ OK ] Package meets the Packaging Guidelines. [ OK ] Package successfully compiles and builds into binary rpms on at least one [ OK ] Buildroot is correct [ OK ] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ OK ] License field in the package spec file matches the actual license. License type: GPL, LGPL, BSD, [ OK ] Spec file is legible and written in American English. [ OK ] Package is not known to require ExcludeArch. [ OK ] All build dependencies are listed in BuildRequires, and aren't redundant. [ OK ] The spec file handles locales properly. [ ? ] ldconfig called in %post and %postun if required. [ OK ] Package must own all directories that it creates. [ OK ] Package does not contain duplicates in %files. [ OK ] Permissions on files are set properly. [ OK ] Package has a %clean section. [ Ok ] Package consistently uses macros. [ OK ] Package contains code, or permissable content. [ OK ] Package uses nothing in %doc for runtime. [ ?/NONE ] Development .so files in -devel subpackage, if present. [ Ok ] Package does not contain any libtool archives (.la). [ NONE ] Package contains a properly installed %{name}.desktop file if it is a GUI application. [ OK ] Package does not own files or directories owned by other packages. == Rpmlint output: == [ OK ] From SRPM package: silent [ ? ] From rpm package: W: mecab-java no-soname /usr/lib64/libMeCab.so
So, would you clarify what is blocking this review request?
the library file "libMeCab.so has no soname but correctly works and doesn't affect any main or other package fonction (just my guess), and i was just waitting a comment from you 'bout that (i.e why you don't try to fix this minor warning) even so.
libMeCab.so is to be dlopen'ed and need not to have sover.
============== ** APPROVED ** ==============
Thank you! Request for CVS admin: -------------------------------------------------- New Package CVS Request ======================= Package Name: mecab-java Short Description: Java binding for MeCab Owners: mtasaka.u-tokyo.ac.jp Branches: F-7 FC-6 InitialCC: (nobody) -------------------------------------------------- --------------------------------------------------
cvs done
Rebuild done. Thank you for the review.