Bug 233425 - Review Request: mecab-java - Java binding for MeCab
Review Request: mecab-java - Java binding for MeCab
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Xavier Lamien
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-03-22 09:04 EDT by Mamoru TASAKA
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-06-22 00:23:26 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
lxtnow: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)
mock: build log on x86_64 (16.49 KB, text/plain)
2007-06-15 23:05 EDT, Xavier Lamien
no flags Details
mecab-java: test.java file containing encoding expression (920 bytes, text/x-java)
2007-06-16 11:20 EDT, Xavier Lamien
no flags Details
test.java.orig (894 bytes, application/octet-stream)
2007-06-16 11:21 EDT, Xavier Lamien
no flags Details

  None (edit)
Description Mamoru TASAKA 2007-03-22 09:04:35 EDT
Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/mecab-java.spec
SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/mecab-java-0.95-1.fc7.src.rpm	
Mock build log on FC-devel i386: ttp://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/LOGS/MOCK-mecab-java.log
Java binding for MeCab.
Comment 2 Xavier Lamien 2007-06-15 19:56:38 EDT
Starting review...
Comment 3 Xavier Lamien 2007-06-15 23:05:18 EDT
Created attachment 157174 [details]
mock: build log on x86_64

Failed to build on test.java from x86_64 arch.
Comment 4 Mamoru TASAKA 2007-06-16 00:37:14 EDT
Would you attach the test.java and test.java.orig on mockbuild x86_64?
Comment 5 Xavier Lamien 2007-06-16 11:20:45 EDT
Created attachment 157191 [details]
mecab-java: test.java file containing encoding expression

It seem that some BR could be missing cause i haven't the necessary font to
print some character and its failed to recognize them.

test.java:24: error: Unrecognized character for encoding 'ANSI_X3.4-1968'.
     System.out.println (tagger.parse
Comment 6 Xavier Lamien 2007-06-16 11:21:11 EDT
Created attachment 157192 [details]
Comment 7 Mamoru TASAKA 2007-06-16 11:50:34 EDT
Well, while I doubt this is related to font issue because
mockbuild sets the LANG value to C and even if I set LANG and LC_ALL
to C the compilation of test.java succeeds for me, currently I
don't know the correct solution. As this is a test java script 
for now I nuked the test.


* Sun Jun 17 2007 Mamoru Tasaka <mtasaka@ioa.s.u-tokyo.ac.jp> - 0.96-2
- Nuke test for now
Comment 9 Xavier Lamien 2007-06-16 12:31:09 EDT
It got me some strange character now but the build pass fine.
I'll work around to find how it could be fix.

For now, mock working...
Comment 10 Xavier Lamien 2007-06-18 14:25:53 EDT
 [ OK ] Tested Arch with Mock: x86_64 (F-7 and FC-6)
 [ OK ] Package is named according to the Package Naming Guidelines.
 [ OK ] Spec file name match the base package %{name}
 [ OK ] Package meets the Packaging Guidelines.
 [ OK ] Package successfully compiles and builds into binary rpms on at least one
 [ OK ] Buildroot is correct
 [ OK ] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [ OK ] License field in the package spec file matches the actual license.
     License type: GPL, LGPL, BSD,
 [ OK ] Spec file is legible and written in American English.
 [ OK ] Package is not known to require ExcludeArch.
 [ OK ] All build dependencies are listed in BuildRequires, and aren't redundant.
 [ OK ] The spec file handles locales properly.
 [ ? ] ldconfig called in %post and %postun if required.
 [ OK ] Package must own all directories that it creates.
 [ OK ] Package does not contain duplicates in %files.
 [ OK ] Permissions on files are set properly.
 [ OK ] Package has a %clean section.
 [ Ok ] Package consistently uses macros.
 [ OK ] Package contains code, or permissable content.
 [ OK ] Package uses nothing in %doc for runtime.
 [ ?/NONE ] Development .so files in -devel subpackage, if present.
 [ Ok ] Package does not contain any libtool archives (.la).
 [ NONE ] Package contains a properly installed %{name}.desktop file if it is a GUI
 [ OK ] Package does not own files or directories owned by other packages.

== Rpmlint output: ==
 [ OK ] From SRPM package: silent
 [ ? ]  From rpm package:

W: mecab-java no-soname /usr/lib64/libMeCab.so

Comment 11 Mamoru TASAKA 2007-06-20 02:42:05 EDT
So, would you clarify what is blocking this review request?
Comment 12 Xavier Lamien 2007-06-20 17:33:51 EDT
the library file "libMeCab.so has no soname but correctly works and doesn't
affect any main or other package fonction (just my guess), and i was just
waitting a comment from you 'bout that (i.e why you don't try to fix this minor
warning) even so.
Comment 13 Mamoru TASAKA 2007-06-21 07:22:33 EDT
libMeCab.so is to be dlopen'ed and need not to have sover.
Comment 14 Xavier Lamien 2007-06-21 09:11:21 EDT

Comment 15 Mamoru TASAKA 2007-06-21 09:50:29 EDT
Thank you!

Request for CVS admin:
New Package CVS Request
Package Name:         mecab-java
Short Description:    Java binding for MeCab
Owners:               mtasaka@ioa.s.u-tokyo.ac.jp
Branches:             F-7 FC-6
InitialCC:            (nobody)
Comment 16 Kevin Fenzi 2007-06-21 22:15:23 EDT
cvs done
Comment 17 Mamoru TASAKA 2007-06-22 00:23:26 EDT
Rebuild done. Thank you for the review.

Note You need to log in before you can comment on or make changes to this bug.