Spec URL: http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-xlib/python-xlib.spec SRPM URL: http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-xlib/python-xlib-0.13-1.fc7.src.rpm Description: The Python X Library is a complete X11R6 client-side implementation, written in pure Python. It can be used to write low-levelish X Windows client applications in Python. Additional Notes: This package is a new requirement for the newly released istanbul 0.2.2 Mock fedora-development-x86 logs available in: http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-xlib/ rpmlint returns clean
I can review this coming week (if no one else gets to it before then). On first glance, packaging looks good/clean, my only suggestion would be to shorten summary a wee bit to something like: Summary: X client library for Python
I'll shorten the summary, in the next srpm/spec set. Though I'm going to hold off on bumping a release of the spec until I know if there's something else I need to change. I hate bumping submission revs for individual non-critical build or run time booboos. -jef
Updated for the summary text change suggestion http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-xlib/python-xlib-0.13-2.fc7.src.rpm http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-xlib/python-xlib.spec So uhm, Rex, anytime you want to start that official review that would be great. -jef
plate... full... but... eating as ... fast as I can... alright, I'm ready for a review now.
sorry for the delay, this one's simple enough, and looks good. Wow, I don't recall ever actually witnesseing a 100% clean (w/o warnings) rpmlint on a package under review before either. neat. My only possible suggestion would be to split the ~660K-ish docs into a separate package (-doc), to ease the runtime weight of python-xlibs. APPROVED.
Okay I spun a new version with a separate doc subpackage if you have a second please take a quick look at the binaries in http://jspaleta.thecodergeek.com/Fedora%20SRPMS/python-xlib/devel/ -jef
New Package CVS Request ======================= Package Name: python-xlib Short Description: X client library for Python Owners: jspaleta Branches: FC-6 InitialCC:
Looks good, except you prolly don't want/need %doc README COPYING in *both* packages (just the main one).
I would like to see this in EPEL6. Would you be willing to support it there, or should I?
Package Change Request ====================== Package Name: python-xlib New Branches: el6 Owners: orion InitialCC:
Git done (by process-git-requests).