Bug 234355 - Review Request: klear - graphical TV viewer with an integrated recording system for Linux
Review Request: klear - graphical TV viewer with an integrated recording syst...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jochen Schmitt
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-28 13:56 EDT by Johan Cwiklinski
Modified: 2007-11-30 17:12 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-09-03 17:59:06 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jochen: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Johan Cwiklinski 2007-03-28 13:56:16 EDT
Spec URL: http://odysseus.x-tnd.be/fedora/klear/klear.spec
SRPM URL: http://odysseus.x-tnd.be/fedora/klear/klear-0.6.0-0.1.src.rpm
Description: Klear is a graphical TV viewer with an integrated recording system
for Linux.
It's designed as a DVB desktop application with all common features.
A clear, nifty and feature rich DVB viewer and recorder
for your desktop machine.
Comment 1 Jochen Schmitt 2007-03-28 15:27:25 EDT
Good:
+ Rpmlint quite on source rpm.
+ Local build works fine.
+ Rpmlint is quite on binary rpm.
+ Rpmlint is quite on debuginfo rpm.
+ Local install and unistall works fine.
+ Naming semms ok.
+ Tar ball matches with upstream.

Bad:
- Build doesn't use $RPM_OPT_FLAGS
- QT Environment variable are not sourced.
Comment 2 Johan Cwiklinski 2007-03-28 18:04:26 EDT
Ok, modifications are applied, thank you.

New URLs are :
Spec URL: http://odysseus.x-tnd.be/fedora/klear/klear.spec
SRPM URL: http://odysseus.x-tnd.be/fedora/klear/klear-0.6.0-1.src.rpm
Comment 3 Jochen Schmitt 2007-03-29 11:13:19 EDT
Good:
+ Source QT environment

Bad:
- Build doesn't use $RPM_OPT_FLAGS
Comment 4 Rex Dieter 2007-03-29 12:26:18 EDT
export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include
should be omitted, these are already included in /etc/profile.d/qt.sh
Comment 5 Jochen Schmitt 2007-05-10 13:03:54 EDT
Ping, Johan
Comment 6 Johan Cwiklinski 2007-05-13 13:53:19 EDT
Ok, I've corrected these points, added desktop-file install and %post/%postun
macros for the icons to be correctly applied after install.

New URLs are :
Spec URL: http://odysseus.x-tnd.be/fedora/klear/klear.spec
SRPM URL: http://odysseus.x-tnd.be/fedora/klear/klear-0.6.0-2.src.rpm
Comment 7 Jochen Schmitt 2007-05-13 14:45:51 EDT
Good:
+ Local build works fine.
+ Mock build works fine.
+ Local install and uninstall works fine.

Bad:
- If I start the applicate, I will got a error message about a misssing
channels.conf.
Comment 8 Jochen Schmitt 2007-06-21 15:37:21 EDT
Ping Johan
Comment 9 Jochen Schmitt 2007-06-27 12:28:53 EDT
In comment #7 I have complaint the startup behavior of the application.

Unfortunately, I don't see any reply related on my complaint.

Comment 10 Johan Cwiklinski 2007-06-27 12:58:45 EDT
I'm sorry but I'm very busy these times :(

Anyone is free to provide a patch fixing the problem, anyways I'll look at this
as soon as I can.

Johan
Comment 11 Rex Dieter 2007-08-18 18:33:51 EDT
suggestion: startup error -> consult upstream?
Comment 12 Johan Cwiklinski 2007-09-02 10:51:47 EDT
There were a new upstream release in July. 
I've packaged these version (0.6.1) and it seems to run fine now (tested on f7
x86_64).

New URLs are : 
Spec URL: http://odysseus.x-tnd.be/fedora/klear/klear.spec
SRPM URL: http://odysseus.x-tnd.be/fedora/klear/klear-0.6.1-1.fc7.src.rpm
Comment 13 Jochen Schmitt 2007-09-03 12:44:00 EDT
OK, the build works fine, and the error message, I will get when no channel.conf
exist is the same as in kubuntu.

So I will APPROVE your package.
Comment 14 Johan Cwiklinski 2007-09-03 13:13:09 EDT
New Package CVS Request
=======================
Package Name: klear
Short Description: DVB TV application and harddisk-recorder for linux
Owners: johan@x-tnd.be
Branches: F-7
InitialCC: johan@x-tnd.be
Cvsextras Commits: yes
Comment 15 Kevin Fenzi 2007-09-03 14:18:45 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.