Spec URL: http://odysseus.x-tnd.be/fedora/klear/klear.spec SRPM URL: http://odysseus.x-tnd.be/fedora/klear/klear-0.6.0-0.1.src.rpm Description: Klear is a graphical TV viewer with an integrated recording system for Linux. It's designed as a DVB desktop application with all common features. A clear, nifty and feature rich DVB viewer and recorder for your desktop machine.
Good: + Rpmlint quite on source rpm. + Local build works fine. + Rpmlint is quite on binary rpm. + Rpmlint is quite on debuginfo rpm. + Local install and unistall works fine. + Naming semms ok. + Tar ball matches with upstream. Bad: - Build doesn't use $RPM_OPT_FLAGS - QT Environment variable are not sourced.
Ok, modifications are applied, thank you. New URLs are : Spec URL: http://odysseus.x-tnd.be/fedora/klear/klear.spec SRPM URL: http://odysseus.x-tnd.be/fedora/klear/klear-0.6.0-1.src.rpm
Good: + Source QT environment Bad: - Build doesn't use $RPM_OPT_FLAGS
export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include should be omitted, these are already included in /etc/profile.d/qt.sh
Ping, Johan
Ok, I've corrected these points, added desktop-file install and %post/%postun macros for the icons to be correctly applied after install. New URLs are : Spec URL: http://odysseus.x-tnd.be/fedora/klear/klear.spec SRPM URL: http://odysseus.x-tnd.be/fedora/klear/klear-0.6.0-2.src.rpm
Good: + Local build works fine. + Mock build works fine. + Local install and uninstall works fine. Bad: - If I start the applicate, I will got a error message about a misssing channels.conf.
Ping Johan
In comment #7 I have complaint the startup behavior of the application. Unfortunately, I don't see any reply related on my complaint.
I'm sorry but I'm very busy these times :( Anyone is free to provide a patch fixing the problem, anyways I'll look at this as soon as I can. Johan
suggestion: startup error -> consult upstream?
There were a new upstream release in July. I've packaged these version (0.6.1) and it seems to run fine now (tested on f7 x86_64). New URLs are : Spec URL: http://odysseus.x-tnd.be/fedora/klear/klear.spec SRPM URL: http://odysseus.x-tnd.be/fedora/klear/klear-0.6.1-1.fc7.src.rpm
OK, the build works fine, and the error message, I will get when no channel.conf exist is the same as in kubuntu. So I will APPROVE your package.
New Package CVS Request ======================= Package Name: klear Short Description: DVB TV application and harddisk-recorder for linux Owners: johan Branches: F-7 InitialCC: johan Cvsextras Commits: yes
cvs done.