Bug 234368 - Review Request: gnome-games-extra-data - themes for gnome-games
Review Request: gnome-games-extra-data - themes for gnome-games
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jochen Schmitt
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-28 14:43 EDT by Matthias Clasen
Modified: 2007-11-30 17:12 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-04-02 17:29:57 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jochen: fedora‑review+
wtogami: fedora‑cvs+


Attachments (Terms of Use)
Local build log (3.00 KB, text/plain)
2007-03-29 10:29 EDT, Jochen Schmitt
no flags Details

  None (edit)
Description Matthias Clasen 2007-03-28 14:43:00 EDT
Spec URL: http://people.redhat.com/mclasen/gnome-games-extra-data/gnome-games-extra-data.spec
SRPM URL: http://people.redhat.com/mclasen/gnome-games-extra-data/gnome-games-extra-data-2.17.90-1.src.rpm
Description: 
The gnome-games-extra-data package includes additional data
and themes for the games in the gnome-games package.

This package is being split off gnome-games to save room on the live cd.
Comment 1 Ray Strode [halfline] 2007-03-28 14:56:20 EDT
> Requires: gnome-games >= 2.18.0-2 

Should this say 2.18.0-2.fc7 ?
Comment 2 Matthias Clasen 2007-03-28 14:57:13 EDT
Actually, it should say 2.18.0-3.fc7
Comment 3 Ray Strode [halfline] 2007-03-28 14:58:02 EDT
you have %define build_tali that i don't see referenced anywhere
Comment 4 Ray Strode [halfline] 2007-03-28 14:59:34 EDT
can we just drop the 

#
# lawyers are fun
# lawyers are fun little
#

comment?  it seems like noise
Comment 5 Matthias Clasen 2007-03-28 15:04:50 EDT
I've copied it from the gnome-games .spec, since it gives at least a hint why
we remove gnometris, but sure, I can remove it or replace it by a more neutral
comment.
Comment 6 Matthias Clasen 2007-03-28 15:05:43 EDT
Spec and srpm updated 
Comment 7 Jochen Schmitt 2007-03-28 15:28:26 EDT
Good:
+ Naming seems ok.
+ License is ok.
+ Tar ball matches upstream.
+ Local build works fine.
+ Rpmlint is ok on binary package.

Bad:
- URL tag is missing.
- Missing %{?_smp_mflags]
Comment 9 Jochen Schmitt 2007-03-29 10:29:43 EDT
Created attachment 151200 [details]
Local build log

Sorry, but something is wrong with your package.

When I try to build it, no binary packages will produced. The end of the build
log look like:
Comment 10 Matthias Clasen 2007-03-29 15:53:55 EDT
Heh. I added the smp flags to the spec file exactly as you asked for. 
Note the closing ] ...

I've fixed that now. New spec file and srpm at the same place.
Comment 11 Jochen Schmitt 2007-04-01 14:44:51 EDT
Good:
+ Naming ok.
+ Tar ball metaches with upstream.
+ rpmlint quite on source package.
+ Local build works fine.
+ Rpmlint quite on binary package.
+ Local install and uninstall works fine.
+ License ok.
+ Package contains verbatin copy of the license text.




Comment 12 Matthias Clasen 2007-04-02 15:13:43 EDT
New Package CVS Request
=======================
Package Name: gnome-games-extra-data 
Short Description: The gnome-games-extra-data package includes additional data
                   and themes for the games in the gnome-games package.
Owners: mclasen@redhat.com
Branches: FC-7
InitialCC: 
Comment 13 Matthias Clasen 2007-04-02 17:29:57 EDT
Built

Note You need to log in before you can comment on or make changes to this bug.