Hi, I made the mistake to package tuxpuck myself while it was already packaged. I cannot believe this as I even was actively involved in finding a new owner for all of Hugo's packages :( If you're interested see bug 234307 Anyways to not let this be a complete waste of time, I've compared Hugo's specfile with mine, and here are some suggested improvements: Real improvements ----------------- * I don't know where the png now used as icon comes from, but tucpuck comes with its own (IMHO better) icon. To use this: 1) Add a BuildRequires ImageMagick 2) Add "convert -transparent white data/icons/%{name}.ico %{name}.png" to the end of %build 3) Change the icon "install" command to install %{name}.png instead of %{SOURCE2} 4) Search replace 48x48 with 32x32 5) Drop the Source2: tag * I don't know if you are aware of this, but there is a special package to divide the games menu in many submenus based on the categories in the .desktop file, see: https://www.redhat.com/archives/fedora-games-list/2007-March/msg00003.html In order for this to work properly its important that the .desktop file contains descriptive categories. Can you please change the Categories=... line into: "Categories=Game;ArcadeGame;SportsGame;" Iow add "SportsGame;" and while you are at it drop the invalid "Application" Category More Cosmetic improvements -------------------------- * Drop the obsolete "--add-category X-Fedora" from the desktop-file-install command * Change the iconcache scriptlets from: " touch --no-create %{_datadir}/icons/hicolor || : if [ -x %{_bindir}/gtk-update-icon-cache ]; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi " into the now standard: " touch --no-create %{_datadir}/icons/hicolor || : %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : " * Add a: "Requires: hicolor-icon-theme" for proper /usr/share/icons/... directory ownership.
All changes made, committed and built for 5,6 and dev. Thanks for the suggestions!