Bug 234566 - RFE: some specfile improvements
RFE: some specfile improvements
Product: Fedora
Classification: Fedora
Component: tuxpuck (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jon Ciesla
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2007-03-30 02:17 EDT by Hans de Goede
Modified: 2007-11-30 17:12 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-03-30 08:32:12 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Hans de Goede 2007-03-30 02:17:46 EDT

I made the mistake to package tuxpuck myself while it was already packaged. I
cannot believe this as I even was actively involved in finding a new owner for
all of Hugo's packages :( If you're interested see bug 234307

Anyways to not let this be a complete waste of time, I've compared Hugo's
specfile with mine, and here are some suggested improvements:

Real improvements
* I don't know where the png now used as icon comes from, but tucpuck comes
  with its own (IMHO better) icon. To use this:
1) Add a BuildRequires ImageMagick
2) Add "convert -transparent white data/icons/%{name}.ico %{name}.png"
   to the end of %build
3) Change the icon "install" command to install %{name}.png instead of
4) Search replace 48x48 with 32x32
5) Drop the Source2: tag

* I don't know if you are aware of this, but there is a special package to
divide the games menu in many submenus based on the categories in the .desktop
file, see:

In order for this to work properly its important that the .desktop file 
contains descriptive categories. Can you please change the Categories=...
line into: "Categories=Game;ArcadeGame;SportsGame;" Iow add "SportsGame;" and
while you are at it drop the invalid "Application" Category

More Cosmetic improvements
* Drop the obsolete "--add-category X-Fedora" from the desktop-file-install 
* Change the iconcache scriptlets from: "
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
   %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
" into the now standard: "
touch --no-create %{_datadir}/icons/hicolor || :
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
* Add a: "Requires: hicolor-icon-theme" for proper /usr/share/icons/... 
  directory ownership.
Comment 1 Jon Ciesla 2007-03-30 08:32:12 EDT
All changes made, committed and built for 5,6 and dev.

Thanks for the suggestions!

Note You need to log in before you can comment on or make changes to this bug.