Spec URL: http://fr2.rpmfind.net/pub/bellet/review/fgfs-base.spec SRPM URL: http://fr2.rpmfind.net/pub/bellet/review/fgfs-base-0.9.10-1.fc6.src.rpm Description: This package contains the base scenery and aircrafts data files for FlightGear This package is noarch, it is big because it contains all the available aircrafts data. It also provides a base Scenery : the area of San Francisco airport. The spec file has an empty %prep section, because the tarball doesn't provide a Makefile, as all the data from the tarball is supposed to land in the same destination data directory.
good: + Naming is ok * Tar ball matches with upstream. + License is ok + Local build works fine. + Binary packagea are ok. Bad: - Pakcage contains no docs. - Pakcage contrains no verbatin copy of the license
ok. I moved doc files and COPYING to the docdir. New SPEC : http://fr2.rpmfind.net/pub/bellet/review/fgfs-base.spec New SRPM : http://fr2.rpmfind.net/pub/bellet/review/fgfs-base-0.9.10-2.fc6.src.rpm
Good: + Package contains verbatin copy of the license text. *** APPROVED ***
Thanks Jochen! New Package CVS Request ======================= Package Name: fgfs-base Short Description: FlightGear base scenery and data files Owners: fabrice Branches: FC-6 InitialCC:
fgfs-base has been successfully build. Thanks for the review.
New Package CVS Request ======================= Package Name: FlightGear-data Short Description: FlightGear base scenery and data files Owners: fabrice Branches: InitialCC: I'll rename this package, because upstream name changed, since version 1.99.5: ftp://ftp.de.flightgear.org/pub/fgfs/Shared/
For package renames, we don't have a hard policy yet, but I would like to suggest the following: - Can you create the new packages with the new names and the needed provides/obsoletes. - Post a link to them on fedora-devel list and/or here. - Once they check out on provides/obsoletes, I can make the new package names in cvs for you, and you can mark the old one as dead.package and import the new one. Does that sound reasonable?
Sure. The concerned packages are here : http://fr2.rpmfind.net/pub/bellet/review/ .fgfs-base is renamed to FlightGear-data .fgfs-Atlas is renamed to FlightGear-Atlas SimGear, FlightGear and FlightGear-data new versions are currently released upstream synchronously, with the same version numbers. FlighGear-Atlas and FlightGear are the only two packages that depend on FlightGear-data, so I updated their Requires accordingly. And no other package depends on FlightGear-Atlas. So I see no use in this case, to continue to provide the old names of these two renamed packages. (I'm maintainer for all the FlightGear-* packages, and comaintainer for SimGear, so I expect to update all these packages in rawhide at the same time) Does it looks good ?
ah typo in fgfs-Atlas.spec. please grab again from the previous url, if you already have.
Yep. That looks good to me from what I can see. I would of course still push to rawhide and confirm it obsoletes as you expect before pushing for f10/f9. So, would you like to just put all the requests here and I can do them at once? Once the new packages are setup, you can dead.package the old ones. Thanks for your patience.
Go ahead and add the requests here (use Fedora account system accounts) and reset the fedora-cvs flag when you are ready.
Ok. New Package CVS Request ======================= Package Name: FlightGear-data Short Description: FlightGear base scenery and data files Owners: bellet Branches: InitialCC: New Package CVS Request ======================= Package Name: FlightGear-Atlas Short Description: Flightgear map tools Owners: bellet Branches: InitialCC: Thanks!
cvs done.
Package Change Request ====================== Package Name: FlightGear-data New Branches: EL-6 Owners: bellet
CVS done (by process-cvs-requests.py).