Description of problem: will report following error when clone a cert whose component = "Component/Peripheral": Insecure dependency in parameter 1 of DBI::db=HASH(0x15e2bd0)->prepare method call while running with -T switch at hwcert.pl line 498. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. Choose a component = "Component/Peripheral" cert 2. click "Create Clone" 3. Actual results: Expected results: Additional info:
This may no longer be an issue after the DB change, will leave open to investigate/fix.
Created attachment 305355 [details] Pls review. The bug is caused by the below codes: my $cert_type = $::FORM{'internal_whiteboard'}; ....... y $status = "Compatible"; if ($cert_type ne "Component/Peripheral") { $cert_type = "SYSTEM"; $status = "Certified"; } else { # Find the test type (AUDIO/NETWORK/STORAGE/etc) and use that as cert_type # This should just work if each of the uploaded packages are similar in tests and # the test ran besides INFO is the type of component being tested. foreach my $i (keys %tests) { foreach my $type (keys %{$tests{$i}}) { next if $type eq 'INFO'; $cert_type = $type; } } } my $cert_id = CreateCertRecord($id, $cert_type, "false", $status, "now()"); When the $cert_type eq "Component/Peripheral", $cert_type needs to be taint before insert it into db. Best Regards! Nicho
if this tests cleanly, please check-in
Have tested well, have checked into cvs. Nicho