Bug 235573 - Review Request: websec - Web page monitoring software with highlighting
Review Request: websec - Web page monitoring software with highlighting
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ville Skyttä
Fedora Package Reviews List
: Reopened
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-04-07 09:36 EDT by Thorsten Leemhuis
Modified: 2007-11-30 17:12 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-05-22 02:36:17 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ville.skytta: fedora‑review+
wtogami: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Thorsten Leemhuis 2007-04-07 09:36:24 EDT
Spec URL:
http://www.leemhuis.info/files/fedorarpms/SPECS.fdr/websec.spec

SRPM URL: 
http://www.leemhuis.info/files/fedorarpms/SRPMS.fdr/websec-1.9.0-1.src.rpm

Description: 
Web Secretary is a web page change monitoring software. It will detect changes
based on content analysis, making sure that it's not just HTML that changed,
but actual content. You can tell it what to ignore in the page (hit counters
and such), and it can mail you the document with the changes highlighted or
load the highlighted page in a browser.

Notes for the reviewer:
* not using dist on purpose
Comment 1 Ville Skyttä 2007-04-07 13:13:46 EDT
- Even though the dep on smtpdaemon probably pulls in the needed thing, it
sounds incorrect; websec just needs a sendmail executable, not a SMTP daemon ->
change dependency to "MTA" or "/usr/sbin/sendmail"?

- %define debug_package stuff + comment can be removed, this is a noarch package.

- s/mozilla/xdg-open/ in the example url.list?
Comment 2 Thorsten Leemhuis 2007-04-07 13:55:50 EDT
Thanks for the review Ville.

(In reply to comment #1)
> - Even though the dep on smtpdaemon probably pulls in the needed thing, it
> sounds incorrect; websec just needs a sendmail executable, not a SMTP daemon ->
> change dependency to "MTA" or "/usr/sbin/sendmail"?

Changed (there are some packages in Fedora that seem to do it like this, but I'm
not sure if they need a daemon or just /usr/sbin/sendmail)

 
> - %define debug_package stuff + comment can be removed, this is a noarch package.

Note to myself: make noarch packages noarch first, before looking at the size of
the debuginfo package ;-)
 
> - s/mozilla/xdg-open/ in the example url.list?

Hmmm; I've thought about it a bit, but I think more people know what "mozilla"
is and does than what "xdg-open" does (which is not installed on any of my
Fedora machines...)

= Updated package = 

Spec URL:
http://www.leemhuis.info/files/fedorarpms/SPECS.fdr/websec.spec

SRPM URL: 
http://www.leemhuis.info/files/fedorarpms/SRPMS.fdr/websec-1.9.0-2.src.rpm

DIFF URL: 
http://www.leemhuis.info/files/fedorarpms/DIFFS.fdr/websec.diff
Comment 3 Ville Skyttä 2007-04-07 14:02:34 EDT
Approved.
Comment 4 Thorsten Leemhuis 2007-04-07 14:18:16 EDT
(In reply to comment #3)
> Approved.

Thanks Ville

New Package CVS Request
=======================
Package Name: websec
Short Description: Web Secretary - Web page monitoring software with highlighting
Owners: fedora@leemhuis.info
Branches: FC-5 FC-6 EL-4 EL-5
Comment 5 Jochen Schmitt 2007-05-20 13:31:41 EDT
Package Change Request
======================
Package Name: highlight
Updated Fedora Ownders: Jochen@herr-schmitt.de,lxtnow@gmail.com
Comment 6 Thorsten Leemhuis 2007-05-22 02:36:17 EDT
/me wonders what a "Package Change Request" for highlight has to do with websec

/me chooses to not care and just closes the bug again

Note You need to log in before you can comment on or make changes to this bug.