Bug 235636 - Review Request: pipepanic - A pipe connecting game
Review Request: pipepanic - A pipe connecting game
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Hans de Goede
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-04-08 13:51 EDT by Andrea Musuruane
Modified: 2007-11-30 17:12 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-05-05 08:43:22 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
hdegoede: fedora‑review+
jwboyer: fedora‑cvs+


Attachments (Terms of Use)
PATCH: set window title and icon (1.02 KB, patch)
2007-05-01 16:32 EDT, Hans de Goede
no flags Details | Diff

  None (edit)
Description Andrea Musuruane 2007-04-08 13:51:19 EDT
Spec URL: http://www.webalice.it/musuruan/RPMS/reviews/pipepanic.spec
SRPM URL: http://www.webalice.it/musuruan/RPMS/reviews/pipepanic-0.1.3-1.src.rpm

Description:
Pipepanic is a pipe connecting game using libSDL that is playable on 
Linux PCs and the Sharp Zaurus. Connect as many different shaped pipes 
together as possible within the time given.
Comment 1 Adam Goode 2007-04-11 10:42:08 EDT
Hi, I'd be happy to review this if you help me out and review a game for me:

Escape:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235588

Data for Escape:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235589
Comment 2 Hans de Goede 2007-04-17 14:06:35 EDT
Andrea, the same goes for me, I would be happy to exchange a review for a review
of any of these:

* asc-music - Background music for the game asc -
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233256 - requires asc
* vegastrike - 3D OpenGL spaceflight simulator -
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233782
* vegastrike-data - Data files for Vega Strike -
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233783
* ballz - Platform game with some puzzle elements -
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236798
Comment 3 Hans de Goede 2007-05-01 10:44:47 EDT
I haven't looked yet, but if this game points / uses Lucas Trademark PipeDream
anywhere, then the use of that TM in docs / credits / etc, must be removed.

For more on this see the pipenightdreams review and spec file, and also:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224627
Comment 4 Andrea Musuruane 2007-05-01 13:29:45 EDT
(In reply to comment #3)
> I haven't looked yet, but if this game points / uses Lucas Trademark PipeDream
> anywhere, then the use of that TM in docs / credits / etc, must be removed.

The few docs shipped do not have such references.
Comment 5 Hans de Goede 2007-05-01 16:31:11 EDT
MUST:
=====
* rpmlint output is clean
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel x86_64
* BR: ok
* No locales
* No shared libraries, ldconfig not needed
* Not relocatable
0 Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code and permissable content
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed
* .desktop file as required and properly installed

MUST FIX
========
* /usr/share/pipepanic is not owned, change:
  %{_datadir}/%{name}/* under files to just %{_datadir}/%{name}

Should FIX
==========
* Drop " that is playable on Linux PCs and the Sharp Zaurus." from %description
  ofcourse it runs on linux, its a Fedora package, and that it also runs
  on the Zaurus is of 0 interest.
* Set a window title, currently the window is untitled. I'll attach a patch for 
  this. Notice that this patch also needs an icon file in bmp format installed
  as /usr/share/pipepanic/icon.bmp

  This file can be generated by the following obscure ImageMagick command,
  and yes the using of convert twice and the | is necessary:
convert PipepanicIcon32.png bmp3:- | convert - -fill '#FF00FF' -opaque black
-colors 256 -compress none bmp3:icon.bmp
Comment 6 Hans de Goede 2007-05-01 16:32:09 EDT
Created attachment 153891 [details]
PATCH: set window title and icon
Comment 7 Andrea Musuruane 2007-05-02 15:23:24 EDT
Spec URL: http://www.webalice.it/musuruan/RPMS/reviews/pipepanic.spec
SRPM URL: http://www.webalice.it/musuruan/RPMS/reviews/pipepanic-0.1.3-2.src.rpm

Changelog:
- Fixed package ownership of its datadir
- Changed description
- Added a patch by Hans de Goede to set a window title and icon
Comment 8 Hans de Goede 2007-05-02 15:33:40 EDT
Looks good now, approved!
Comment 9 Andrea Musuruane 2007-05-03 03:47:34 EDT
New Package CVS Request
=======================
Package Name: pipepanic
Short Description: A pipe connecting game    
Owners: musuruan@gmail.com
Branches: FC-5 FC-6
InitialCC:
Comment 10 Andrea Musuruane 2007-05-05 08:43:22 EDT
Thanks for the review.

Built successfully. Closing.

Note You need to log in before you can comment on or make changes to this bug.