Spec URL: http://fedora.allisson.eti.br/clutter-gtk/clutter-gtk.spec SRPM URL: http://fedora.allisson.eti.br/clutter-gtk/clutter-gtk-0.1.0-1.src.rpm Description: This allows clutter to be embedded in GTK applications. We hope with further work in the future clutter-gtk will also allow the reverse, namely embedding GTK in Clutter
Perhaps this can be approved with some few fixes (if any)
* Should/Must fix ! Suggestion or something else ? Question For 0.1.0-1: ! Redundant dependencies (NOT A BLOCKER) - gtk2-devel is required by clutter-devel (as clutter-devel requires gdk-pixbuf-2.0.pc). So "(Build)Requires: gtk2-devel" can be removed. However for this package I don't force you to remove "gtk2-devel" because clutter-gtk.pc explicitly requires gtk+-2.0.pc. * File/directory ownership issue - The following directories are already owned by other packages and should not be owned by these packages. -------------------------------------------------------- /usr/include/clutter-0.2 owned by clutter-devel -------------------------------------------------------- * Documentation - The following files should not be installed as documentation -------------------------------------------------------- INSTALL - this file is needed for people who want to install this software by themselves and is not needed for rpm management. -------------------------------------------------------- * Timestamps - This package installs some files which are not built or modified during rebuild (header file and documentation), and keeping timestamps on these files is highly recommended. For this package, please use the following: -------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p" -------------------------------------------------------- ? License (NOT A BLOCKER) - Well, actually COPYING file declares that this is licensed under GPL, however all sources are licensed under LGPL and license.html also says this is LGPL-licensed. Would you ask which license is correct? (either is okay so this is not a blocker)
Update package: Spec URL: http://fedora.allisson.eti.br/clutter-gtk/clutter-gtk.spec SRPM URL: http://fedora.allisson.eti.br/clutter-gtk/clutter-gtk-0.1.0-2.src.rpm Changelog: - INSTALL removed from docs - fix make install for keeping timestamps - fix files section - changed license for LGPL
For -2: This time %{_includedir}/clutter-0.2/clutter-gtk/ is not owned by any package and this directory should be owned by -devel package. Pleasse fix this (you can attach spec file) and I can approve this package.
Update package: Spec URL: http://fedora.allisson.eti.br/clutter-gtk/clutter-gtk.spec SRPM URL: http://fedora.allisson.eti.br/clutter-gtk/clutter-gtk-0.1.0-3.src.rpm Changelog: - fix devel files section
Okay!! ------------------------------------------------------- This package (clutter-gtk) is APPROVED by me -------------------------------------------------------
New Package CVS Request ======================= Package Name: clutter-gtk Short Description: basic GTK clutter widget Owners: allisson Branches: FC-6
Please close when rebuld is done.