Spec URL: http://home.arcor.de/christoph.wickert/fedora/extras/review/SPECS/xfce4-verve-plugin.spec SRPM URL: http://home.arcor.de/christoph.wickert/fedora/extras/review/SRPMS/xfce4-verve-plugin-0.3.5-2.fc7.src.rpm Description: This plugin is like the (quite old) xfce4-minicmd-plugin, except that it ships more cool features, such as: * Command history * Auto-completion (including command history) * Open URLs and eMail addresses in your favourite applications * Focus grabbing via D-BUS (so you can bind a shortcut to it) * Custom input field width Note: I'm thinking about orphaning xfce4-minicmd-plugin after this package has been added to the repo.
I'd be happy to review this package. Look for a full review in a few.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 85701b960da6bb10762b460c23b84c15 verve-plugin-0.3.5.tar.bz2 85701b960da6bb10762b460c23b84c15 verve-plugin-0.3.5.tar.bz2.1 OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. Should the "Requires: xfce4-panel >= 4.4.0" be 4.4.1, since we know that in fc6/devel/f7 at least it will be built against 4.4.1, so perhaps it should require at least that version? No big deal, since 4.4.0 and 4.4.1 should be pretty much the same for xfce4-panel-devel, but just thought I would mention it. Not a blocker. As hard as I may try I can't see anything blocking this package. ;) This package is APPROVED. Don't forget to close this review request once it's been imported and built
> 1. Should the "Requires: xfce4-panel >= 4.4.0" be 4.4.1, since > we know that in fc6/devel/f7 at least it will be built against 4.4.1, > so perhaps it should require at least that version? I usually tend to require one version below the one in the repo (if possible), to avoid yum from running when it can't find when the latest version (e. g. because mirrors are not in sync). But I can change it to 4.4.1, the required packages are in the repo for quite a while. New Package CVS Request ======================= Package Name: xfce4-verve-plugin Short Description: A comfortable command line plugin for the Xfce panel Owners: fedora Branches: FC-6 InitialCC: kevin
Package Change Request ====================== Package Name: xfce4-verve-plugin New Branches: epel7 Owners: cwickert InitialCC: nonamedotc
Git done (by process-git-requests).