Bug 239369 (perl-Sys-Syscall) - Review Request: perl-Sys-Syscall - Access system calls that Perl doesn't normally provide access to
Summary: Review Request: perl-Sys-Syscall - Access system calls that Perl doesn't norm...
Status: CLOSED NEXTRELEASE
Alias: perl-Sys-Syscall
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chris Weyl
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-05-07 21:57 UTC by Ruben Kerkhof
Modified: 2011-07-15 14:00 UTC (History)
1 user (show)

(edit)
Clone Of:
(edit)
Last Closed: 2007-05-12 17:18:20 UTC
cweyl: fedora-review+


Attachments (Terms of Use)

Description Ruben Kerkhof 2007-05-07 21:57:44 UTC
Spec URL: http://rubenkerkhof.com/packages/perl-Sys-Syscall.spec
SRPM URL: http://rubenkerkhof.com/packages/perl-Sys-Syscall-0.22-1.src.rpm
Description:
Use epoll, sendfile, from Perl. Mostly Linux-only support now, but more
syscalls/OSes planned for future.

Comment 1 Chris Weyl 2007-05-08 01:38:55 UTC
Changelog entry is a touch weird -- you should add your email addy, even if
it's in <foo at bar.org> format.

Missing BR on perl(Test::More).

Correct the above two and I'll approve :)

+ source files match upstream:
 a29b1ddd6fea9f7e11f0f82534d4204c  Sys-Syscall-0.22.tar.gz
 a29b1ddd6fea9f7e11f0f82534d4204c  ../Sys-Syscall-0.22.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream.
+ latest version is being packaged.
X BuildRequires are proper.
+ compiler flags are appropriate. (noarch)
+ %clean is present.
+ package installs properly
+ rpmlint is silent.
+ final provides and requires are sane:
 ** perl-Sys-Syscall-0.22-1.fc6.noarch.rpm
 == rpmlint
 == provides
 perl(Sys::Syscall) = 0.22
 perl-Sys-Syscall = 0.22-1.fc6
 == requires
 perl(:MODULE_COMPAT_5.8.8)  
 perl(Config)  
 perl(Exporter)  
 perl(POSIX)  
 perl(constant)  
 perl(strict)  
 perl(vars)  
+ %check is present and all tests pass:
 All tests successful.
 Files=3, Tests=23,  2 wallclock secs ( 0.21 cusr +  0.09 csys =  0.30 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.

Comment 2 Ruben Kerkhof 2007-05-08 07:18:02 UTC
Hi Chris, thanks for the review.

New version at
http://rubenkerkhof.com/packages/perl-Sys-Syscall.spec
SRPM: http://rubenkerkhof.com/packages/perl-Sys-Syscall-0.22-2.src.rpm

Comment 3 Chris Weyl 2007-05-09 14:06:30 UTC
APPROVED

Comment 4 Ruben Kerkhof 2007-05-09 17:00:55 UTC
New Package CVS Request
=======================
Package Name: perl-Sys-Syscall
Short Description: Access system calls that Perl doesn't normally provide access to
Owners: ruben@rubenkerkhof.com
Branches: FC-5 FC-6

Comment 5 Ruben Kerkhof 2007-08-07 19:46:54 UTC
Package Change Request
======================
Package Name: perl-Sys-Syscall
New Branches: EL-4 EL-5

Comment 6 Jason Tibbitts 2007-08-07 22:34:23 UTC
I'm seeing perl-Sys-Syscall as having been branched for EPEL on May 15, 2007. 
So I guess it's already been done.

Comment 7 Petr Pisar 2011-07-13 08:58:59 UTC
Package Change Request
======================
Package Name: perl-Sys-Syscall
Branches: f15 f14
New InitialCC: perl-sig

Please add `perl-sig' to CC list for all Fedora branches as this is Perl
package.

Comment 8 Gwyn Ciesla 2011-07-15 14:00:10 UTC
This is now done through pkgdb.


Note You need to log in before you can comment on or make changes to this bug.