Bug 239973 (perl-JSON-XS) - Review Request: perl-JSON-XS - JSON serialising/deserialising, done correctly and fast
Summary: Review Request: perl-JSON-XS - JSON serialising/deserialising, done correctly...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-JSON-XS
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL: http://search.cpan.org/dist/JSON-XS/
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-05-13 17:19 UTC by Chris Weyl
Modified: 2007-11-30 22:12 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-05-15 04:59:58 UTC
Type: ---
Embargoed:
j: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2007-05-13 17:19:06 UTC
SRPM URL: http://home.comcast.net/~ckweyl/perl-JSON-XS-1.21-1.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-JSON-XS.spec

Description:
This module converts Perl data structures to JSON and vice versa. Its
primary goal is to be correct and its secondary goal is to be fast. To
reach the latter goal it was written in C.

Comment 1 Chris Weyl 2007-05-13 17:20:34 UTC
In the next "not minor" release of perl-JSON, this module will be transparently
usable as the backend of JSON, much as Readonly::XS is to Readonly or
Class::C3::XS is to Class::C3.

Comment 2 Jason Tibbitts 2007-05-15 01:44:41 UTC
A clean package; The only question I have is why you didn't include the "eg"
directory as documentation.  I guess it only holds a benchmark.

* source files match upstream:
   dc574ce851b8334d29dac844eec5a74b88f985c1b76e389a1e8a7407dd81c4b0  
   JSON-XS-1.21.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream (COPYING just says "same as Perl")
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   XS.so()(64bit)
   perl(JSON::XS) = 1.21
   perl-JSON-XS = 1.21-1.fc7
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(strict)

* %check is present and all tests pass:
   All tests successful.
   Files=16, Tests=24726, 4 wallclock secs ( 3.14 cusr +  0.23 csys = 3.37 CPU)
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la droppings.

APPROVED

Comment 3 Chris Weyl 2007-05-15 02:00:42 UTC
(In reply to comment #2)
> A clean package; The only question I have is why you didn't include the "eg"
> directory as documentation.  I guess it only holds a benchmark.

Purely an oversight on my part; I'll include it in %doc.

Comment 4 Chris Weyl 2007-05-15 02:02:01 UTC
New Package CVS Request
=======================
Package Name: perl-JSON-XS
Short Description: JSON serialising/deserialising, done correctly and fast
Owners: cweyl.edu
Branches: FC-5, FC-6, devel
InitialCC: fedora-perl-devel-list

Comment 5 Chris Weyl 2007-05-15 04:59:58 UTC
Imported and building.  Thanks for the review! :)

Comment 6 Chris Weyl 2007-10-13 21:47:21 UTC
Please branch for F-8 :)

Comment 7 Kevin Fenzi 2007-10-14 19:46:59 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.