Bug 240174 - Review Request: perl-Text-TabularDisplay - Display text in formatted table output
Summary: Review Request: perl-Text-TabularDisplay - Display text in formatted table ou...
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
URL: http://search.cpan.org/dist/Text-Tabu...
Whiteboard:
Keywords:
Depends On:
Blocks: 240177
TreeView+ depends on / blocked
 
Reported: 2007-05-15 16:40 UTC by Chris Weyl
Modified: 2010-09-02 21:17 UTC (History)
1 user (show)

(edit)
Clone Of:
(edit)
Last Closed: 2007-05-16 23:37:27 UTC
tibbs: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2007-05-15 16:40:21 UTC
SRPM URL: http://home.comcast.net/~ckweyl/perl-Text-TabularDisplay-1.22-1.fc6.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Text-TabularDisplay.spec

Description:
Text::TabularDisplay simplifies displaying textual data in a table. The
output is identical to the columnar display of query results in the mysql
text monitor. For example, this data:

Comment 1 Jason Tibbitts 2007-05-15 20:56:45 UTC
I only have one question:  The tests seem to need perl(Test) while you have a
build-time dependency on perl(Test::More).  At this point I'm not sure what the
plan is, but as is I'd wager that you have the wrong BuildRequire there.  Since
we chatted about this on IRC, I'll go ahead and approve this and you can check
in with the quick fix.

* source files match upstream:
   87856a053cccba8059c194da15300271ea800ab37c44e01f34612be4da962317  
   Text-TabularDisplay-1.22.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream (GPL statement is in the code itself)
* latest version is being packaged.
? BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(Text::TabularDisplay) = 1.22
   perl-Text-TabularDisplay = 1.22-1.fc7
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(integer)
   perl(strict)
   perl(vars)

* %check is present and all tests pass:
   All tests successful.
   Files=15, Tests=83,  0 wallclock secs ( 0.20 cusr +  0.14 csys =  0.34 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 2 Chris Weyl 2007-05-15 20:58:57 UTC
New Package CVS Request
=======================
Package Name: perl-Text-TabularDisplay
Short Description: Display text in formatted table output
Owners: cweyl@alumni.drew.edu
Branches: FC-5, FC-6, devel
InitialCC: fedora-perl-devel-list@redhat.com

Comment 3 Chris Weyl 2007-05-16 23:37:07 UTC
Imported and building.  As always, thanks for the review! :)

Comment 4 Iain Arnell 2010-09-02 14:38:03 UTC
Package Change Request
======================
Package Name: perl-Text-TabularDisplay
New Branches: el6
Owners: iarnell tremble

Comment 5 Kevin Fenzi 2010-09-02 21:17:42 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.