Bug 240705 - Review Request: yafray - Yet Another Free RAYtracer
Summary: Review Request: yafray - Yet Another Free RAYtracer
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jochen Schmitt
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-05-20 22:57 UTC by Nicolas Chauvet (kwizart)
Modified: 2007-11-30 22:12 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-05-23 00:18:28 UTC
Type: ---
Embargoed:
jochen: fedora-review+
tcallawa: fedora-cvs+


Attachments (Terms of Use)

Description Nicolas Chauvet (kwizart) 2007-05-20 22:57:01 UTC
Spec URL:
http://kwizart.free.fr/fedora/7/testing/yafray/yafray.spec
SRPM URL: 
http://kwizart.free.fr/fedora/7/testing/yafray/yafray-0.0.9-1.kwizart.fc7.src.rpm
Description: Yet Another Free RAYtracer

The question does libs it requires symlinks i don't knwo how yafray is uses inside blender (testing for now...)

Comment 1 Jochen Schmitt 2007-05-21 19:51:30 UTC
good:
+ Naming seems ok
+ Tar ball matches with upstream.
+ License seems ok.
+ Rpmlint of source package ok
+ Rpmlint ok for debuginfo.
+ Local install and uninstall works fine.
+ Mock build works fine for FC6 and F7 (x86_64)

Bad:
- Rpmlint complaints binary package:
rpmlint yafray-0.0.9-1.x86_64.rpm
E: yafray zero-length /usr/share/doc/yafray-0.0.9/NEWS
W: yafray non-conffile-in-etc /etc/gram.yafray
E: yafray zero-length /usr/share/doc/yafray-0.0.9/COPYING
W: yafray incoherent-version-in-changelog 0.0.9-2 0.0.9-1
E: yafray invalid-soname /usr/lib64/libyafraycore.so libyafraycore.so
E: yafray invalid-soname /usr/lib64/libyafrayplugin.so libyafrayplugin.so
- Rpmlint complaints on installed package:
rpmlint yafray
E: yafray zero-length /usr/share/doc/yafray-0.0.9/NEWS
W: yafray non-conffile-in-etc /etc/gram.yafray
E: yafray zero-length /usr/share/doc/yafray-0.0.9/COPYING
W: yafray incoherent-version-in-changelog 0.0.9-2 0.0.9-1
E: yafray invalid-soname /usr/lib64/libyafrayplugin.so libyafrayplugin.so
W: yafray unused-direct-shlib-dependency /usr/lib64/libyafrayplugin.so
/lib64/libdl.so.2
W: yafray unused-direct-shlib-dependency /usr/lib64/libyafrayplugin.so
/lib64/libpthread.so.0
W: yafray unused-direct-shlib-dependency /usr/lib64/libyafrayplugin.so
/lib64/libm.so.6
E: yafray invalid-soname /usr/lib64/libyafraycore.so libyafraycore.so
W: yafray undefined-non-weak-symbol /usr/lib64/libyafraycore.so dlsym
W: yafray undefined-non-weak-symbol /usr/lib64/libyafraycore.so dlerror
W: yafray undefined-non-weak-symbol /usr/lib64/libyafraycore.so dlopen
W: yafray undefined-non-weak-symbol /usr/lib64/libyafraycore.so dlclose
W: yafray unused-direct-shlib-dependency /usr/lib64/libyafraycore.so
/usr/lib64/libImath.so.4
W: yafray unused-direct-shlib-dependency /usr/lib64/libyafraycore.so
/usr/lib64/libIex.so.4



Comment 2 Nicolas Chauvet (kwizart) 2007-05-21 22:32:12 UTC
Spec URL:
http://kwizart.free.fr/fedora/7/testing/yafray/yafray.spec
SRPM URL: 
http://kwizart.free.fr/fedora/7/testing/yafray/yafray-0.0.9-2.kwizart.fc6.src.rpm
Description: Yet Another Free RAYtracer

Sorry i may have uploaded the wrong file...

All errors are removed but some warnings remain: (on installed files)
rpmlint yafray
W: yafray incoherent-version-in-changelog 0.0.9-2 0.0.9-2.kwizart.fc6
W: yafray undefined-non-weak-symbol /usr/lib64/libyafraycore.so.0.0.9 dlsym
W: yafray undefined-non-weak-symbol /usr/lib64/libyafraycore.so.0.0.9 dlerror
W: yafray undefined-non-weak-symbol /usr/lib64/libyafraycore.so.0.0.9 dlopen
W: yafray undefined-non-weak-symbol /usr/lib64/libyafraycore.so.0.0.9 dlclose
W: yafray unused-direct-shlib-dependency /usr/lib64/libyafraycore.so.0.0.9
/usr/lib64/libImath.so.4
W: yafray unused-direct-shlib-dependency /usr/lib64/libyafraycore.so.0.0.9
/usr/lib64/libIex.so.4
W: yafray unused-direct-shlib-dependency /usr/lib64/libyafrayplugin.so.0.0.9
/lib64/libdl.so.2
W: yafray unused-direct-shlib-dependency /usr/lib64/libyafrayplugin.so.0.0.9
/lib64/libpthread.so.0
W: yafray unused-direct-shlib-dependency /usr/lib64/libyafrayplugin.so.0.0.9
/lib64/libm.so.6

Searching about a proper fix from here:
http://sources.redhat.com/ml/libc-alpha/2003-05/msg00034.html

Comment 3 Jochen Schmitt 2007-05-22 17:25:22 UTC
(In reply to comment #2)

> W: yafray undefined-non-weak-symbol /usr/lib64/libyafraycore.so.0.0.9 dlclose
> W: yafray unused-direct-shlib-dependency /usr/lib64/libyafraycore.so.0.0.9
> /usr/lib64/libImath.so.4

Please report this issue to the upstream.

Comment 4 Jochen Schmitt 2007-05-22 17:34:03 UTC
Good:
+ Rpmlint is quite on binary packages
+ Package contain verbain copy of the license test.
+ Start yafray from command line without arguments without a crash.

*** APPROVED ***



Comment 5 Nicolas Chauvet (kwizart) 2007-05-22 18:44:15 UTC
New Package CVS Request
=======================
Package Name: yafray
Short Description: Yet Another Free RAYtracer
Owners: kwizart
Branches: FC-6 F-7 devel
InitialCC: 

Comment 6 Tom "spot" Callaway 2007-05-22 19:17:18 UTC
CVS done.


Note You need to log in before you can comment on or make changes to this bug.