Spec URL: http://community.moertel.com/rpms/fedora/6/SPECS/R-Matrix.spec SRPM URL: http://community.moertel.com/rpms/fedora/6/SRPMS/R-Matrix-0.9975-1.src.rpm Description: I have packaged a number of CRAN packages for the R statistical-computing system. See the following for the full list: http://blog.moertel.com/articles/2007/04/25/new-fedora-core-rpms-for-cran-packages After discussions about the packages on the fedora-r-devel-list, I am submitting them for review, starting with R-Matrix. For background, please see: https://www.redhat.com/archives/fedora-r-devel-list/2007-April/msg00003.html If there are any problems with this package's spec, they are likely to exist in my other packages as well, so I would like to flush them out with an initial submission before submitting the rest. Please let me know if there is anything I can do to improve my packaging technique. Cheers, Tom
Please note that this is my first package submission, and I am seeking a sponsor.
Couple of minor items: You probably want to have: BuildRequires: libgfortran-devel (you're linking to it) The BuildRequires: R is correct, but BuildRequires: R-devel may be needed for other CRAN packages (if they're looking for libR.pc), and it will drag in R as a dependency. Might not be a bad idea to script it that way to be safe. You need to mkdir -p %{buildroot}%{_libdir}/R/library before running R CMD INSTALL into it. :)
Also: [spot@localhost ~]$ rpmlint /home/spot/rpmbuild/RPMS/x86_64/R-Matrix-0.9975-1.fc7.x86_64.rpm /home/spot/rpmbuild/SRPMS/R-Matrix-0.9975-1.fc7.src.rpm /home/spot/rpmbuild/RPMS/x86_64/R-Matrix-debuginfo-0.9975-1.fc7.x86_64.rpm W: R-Matrix devel-file-in-non-devel-package /usr/lib64/R/library/Matrix/include/Matrix.h W: R-Matrix devel-file-in-non-devel-package /usr/lib64/R/library/Matrix/include/Matrix_stubs.c W: R-Matrix devel-file-in-non-devel-package /usr/lib64/R/library/Matrix/include/cholmod.h W: R-Matrix incoherent-version-in-changelog 1.0-1 0.9975-1.fc7 The devel files look like they belong in a -devel subpackage. The changelog entry needs to be corrected, your script seems to be spitting out a generic one that doesn't match the package version (and is omitting your name).
(In reply to comment #2) > Couple of minor items: > > You probably want to have: BuildRequires: libgfortran-devel (you're linking to it) libgfortran-devel doesn't exist as such, it is linked automatically in when linking with gcc -lgfortran/gfortran. A BuildRequires: gcc-gfortran is missing however. Also looking at the log, it seems that during the link gcc is used and there is a -lgfortran. In my recalling this is not what should be done, instead gfortran should be used during the link and -lgfortran should be omitted. This may be for upstream, or a R bug, however, I don't know exactly.
Tom "spot" Callaway: Is the preferred way of placing devel files in a -devel subpackage documented anywhere? (I didn't see anything on the topic in the Packaging Guidelines.) If there is a preferred way of doing it, I'd rather not guess what it is. :) Thanks for your help.
I have revised the spec at the aforelinked-to location to fix the problems noted earlier. Note that the -devel package is built for the same arch as the main pacakge, but it contains only .c and .h files, so rpmlint complains that it should be built as noarch.
Note: I also updated the package to the recently released upstream version, 0.99875-1. The corresponding SRPM can be downloaded here: http://community.moertel.com/rpms/fedora/6/SRPMS/R-Matrix-0.99875-1.src.rpm
There is a very minor issue with this package, but it doesn't hold up approval. - rpmlint says you've got mixed spaces and tabs, look at line 29. Fix that item before requesting builds, and we're good. Nice work with the -devel package. Good: - rpmlint checks return: W: R-Matrix mixed-use-of-spaces-and-tabs (spaces: line 29, tab: line 5) W: R-Matrix-devel no-documentation E: R-Matrix-devel only-non-binary-in-usr-lib Safe to ignore the Error (all R packages do that), and the no-docs in -devel. - package meets naming guidelines - package meets packaging guidelines - license (Distributable) OK, text in package, matches source (code is a mix of MIT, GPL, LGPL, documented in spec) - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files APPROVED. I'll also sponsor you, thanks for your good work.
Did anything ever happen here? The package is approved and sponsorship was offered eight months ago, yet I don't see Tom in the cvsextras group and of course the package is not in the distro.
Jason, thanks for the ping. I suspect that momentum on this packaging attempt got lost during the Extras merge, which occurred around the time of the submission. I'd like to resume the process. What's the best way to restart it? Cheers, Tom
Since it's been quite some time, I'd go ahead and check the package against the latest R packaging guidelines at http://fedoraproject.org/wiki/Packaging/R, then put links to the spec and srpm here, and then spot can give it another look. hopefully spot's still listening and still willing to sponsor you.
Yeah, please make sure the spec meets the R packaging guidelines, then post it here (if any changes need to be made). I'll give it another quick pass, and then sponsor you upon completion. :)
Great! I tweaked the spec per the most-recent R-packaging guidelines and also updated to Matrix version 0.999375-4. New spec and SRPM: http://community.moertel.com/rpms/fedora/8/SPECS/R-Matrix.spec http://community.moertel.com/rpms/fedora/8/SRPMS/R-Matrix-0.999375-1.fc8.src.rpm Please let me know if you need any changes.
Just checking in: Do I need to do anything else before review? (I've linked to the spec and srpm in the previous comment.) Cheers, Tom
Only items I see: * Your changelog says you're at -4, but you forgot to increment release to 4. Just make sure that your %changelog matches. :) Good: - rpmlint checks return: R-Matrix.x86_64: W: incoherent-version-in-changelog 0.999375-4 0.999375-1.fc9 R-Matrix.x86_64: W: one-line-command-in-%post /usr/lib/rpm/R-make-search-index.sh R-Matrix.x86_64: W: one-line-command-in-%postun /usr/lib/rpm/R-make-search-index.sh R-Matrix-devel.x86_64: W: no-documentation No blockers there, just be careful with matching n-v-r and changelog. - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, text in %doc, matches source (explanation in spec) - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - devel requires base package n-v-r APPROVED (just fix the release before committing). Get your account here, and follow the rest of the steps: http://fedoraproject.org/wiki/PackageMaintainers/Join#head-a601c13b0950a89568deafa65f505b4b58ee869b
Thanks for the re-review. I'll fix the changelog. I already have an account. I just need cvsextras approval to move forward. :-) Note: This is the point where things got bogged down last time, so maybe something is wrong with the state of my account ("tmoertel"). Please let me know if you find any problems. Cheers, Tom
Just a quick check-in ping. :-) Can we move the process forward somehow? (Are you waiting on something from me?) Cheers, Tom
Sorry, I never saw the sponsor request come through. You're sponsored now, and have cvsextras approval. Follow the next steps on the Join link I pasted above.
New Package CVS Request ======================= Package Name: R-Matrix Short Description: R module, Classes etc. for dense and sparse matrices and matrix ops Owners: tmoertel Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done. Removing NEEDSPONSOR.