Red Hat Bugzilla – Bug 241804
Review Request: audio-entropyd - Generate entropy from audio output
Last modified: 2007-11-30 17:12:05 EST
Spec URL: http://www.auroralinux.org/people/spot/review/audio-entropyd.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/audio-entropyd-1.0.0-1.fc7.src.rpm
Audio-entropyd generates entropy-data for the /dev/random device.
Note that the service is enabled by default. Since this daemon needs no configuration, I say that people installing it want it to be running by default.
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version
1. rpmlint has one lone line of output:
W: audio-entropyd service-default-enabled /etc/rc.d/init.d/audio-entropyd
As you say there shouldn't be a problem enabling this by default.
2. Should there be a condrestart for upgrades? You can add one if you think
it makes sense.
I see no blockers, so this package is APPROVED.
Don't forget to close this review once you have imported and built this package.
Added a condrestart to postun, thanks for the suggestion.
Did my own CVS, here it is for reference:
New Package CVS Request
Package Name: audio-entropyd
Short Description: Generate entropy from audio output
Branches: FC-5 FC-6 F-7
Built, and pushing. Thanks for the review.