Spec URL: http://dmitry.butskoy.name/freetds/freetds.spec SRPM URL: http://dmitry.butskoy.name/freetds/freetds-0.64-4.src.rpm Description: FreeTDS is a project to document and implement the TDS (Tabular DataStream) protocol. TDS is used by Sybase(TM) and Microsoft(TM) for client to database server communications. FreeTDS includes call level interfaces for DB-Lib, CT-Lib, and ODBC.
May be avoid trademarks in the Summary?...
Looks like we can't include FreeTDS into main Fedora's repo: http://fedoraproject.org/wiki/ForbiddenItems#FreeTDS You'd better post review request to Livna's bugzilla.
(In reply to comment #1) > May be avoid trademarks in the Summary?... > Yes that would be a good idea. (In reply to comment #2) > Looks like we can't include FreeTDS into main Fedora's repo: > > http://fedoraproject.org/wiki/ForbiddenItems#FreeTDS > > You'd better post review request to Livna's bugzilla. That info is out of date, see the recent thread on the fedora-devel mailinglist. I've updated the wiki to match the current state of afairs, this ackage actually comes from livna and is moving to Fedora, with permission of Tom "Spot" Callaway (@redhat.com).
ping Hans... :)
MUST: ===== * rpmlint output is: W: freetds strange-permission freetds.spec 0666 W: freetds strange-permission freetds-0.64-makefile-doc.patch 0666 W: freetds strange-permission freetds-0.64.tar.gz 0666 # You should check these, might be something with my setup though * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel x86_64 * BR: ok * No locales * Shared libraries, ldconfig run as required * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * -devel package as needed * no .desktop file required Should Fix ========== * This: cr=`echo -en '\r'` sed -i "s/$cr//" doc/tds_ssl.html Is a rather convoluted way of saying this: sed -i 's/\r//' doc/tds_ssl.html About the trademarks in the description, I think there is no other sensible way to describe this package and that the TM use is a typical case of fair use. You might want to add a sentence: "All trademarks are the property of their respective owners". I see no blockers, approved!
> strange permission 0666 Livna does not play with umask too... :) > sed -i 's/\r//' doc/tds_ssl.html Sure, done. Summary changed to just: "Implementation of the TDS (Tabular DataStream) protocol"
New Package CVS Request ======================= Package Name: freetds Short Description: Implementation of the TDS (Tabular DataStream) protocol Owners: dmitry Branches: FC-6 F-7 InitialCC:
Build OK, see results at http://koji.fedoraproject.org/packages/freetds/
Package Change Request ====================== Package Name: freetds New Branches: EL-4 EL-5