Red Hat Bugzilla – Bug 243927
Review Request: xfce4-volstatus-icon - System tray icon to easily eject removable devices
Last modified: 2007-11-30 17:12:07 EST
Spec URL: http://home.arcor.de/christoph.wickert/fedora/review/xfce4-volstatus-icon.spec
SRPM URL: http://home.arcor.de/christoph.wickert/fedora/review/xfce4-volstatus-icon-0.1.0-1.fc8.src.rpm
Description: Xfce4 Volstatus Icon is a system tray icon that allows you to easily eject removable devices from your system, without needing to open a terminal or
I'd be happy to review this. Look for a full review after a while here.
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane.
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
No blockers/issues at all, hard as I try to find one. ;)
This package is APPROVED. Don't forget to close this request once it's been
imported and built.
New Package CVS Request
Package Name: xfce4-volstatus-icon
Short Description: System tray icon to easily eject removable devices
Branches: FC-6 F-7
xfce4-volstatus-icon-0.1.0-1.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report.
xfce4-volstatus-icon-0.1.0-1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.