Bug 243951 (pbm2l7k-review) - Review Request: pbm2l7k - Converts PBM stream to Lexmark 7000, 7200 and 5700 printer language
Summary: Review Request: pbm2l7k - Converts PBM stream to Lexmark 7000, 7200 and 5700 ...
Alias: pbm2l7k-review
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Marek Mahut
QA Contact: Fedora Extras Quality Assurance
Keywords: HardwareEnablement
Depends On:
TreeView+ depends on / blocked
Reported: 2007-06-12 22:01 UTC by Lubomir Kundrak
Modified: 2007-11-30 22:12 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-07-02 09:48:37 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mmahut: fedora-review+
tibbs: fedora-cvs+

Attachments (Terms of Use)

Description Lubomir Kundrak 2007-06-12 22:01:47 UTC
Spec URL: http://people.redhat.com/lkundrak/SPECS/pbm2l7k.spec
SRPM URL: http://people.redhat.com/lkundrak/SRPMS/pbm2l7k-990321-1.src.rpm
Description: Converts bitcmyk data to Lexmark 2050 printer language

This is a filter to convert pbmraw data such as produced by ghostscript to
the printer language of Lexmark 7000, 7200 and 5700 printers.  It is meant
to be used by the PostScript Description files of the drivers from the
foomatic package.

Note: This package is a part of the ongoing effort to extend hardware support
by fixing the foomatic drivers that actually refer to external filters.

Comment 1 Marek Mahut 2007-06-13 21:34:30 UTC
Your symlink isn't relative, the compilation on my machine failed for this reason

   RPM build errors:
      File not found: /var/tmp/pbm2l7k-990321-1.fc7-root-root/usr/bin/pbm2lex

you should use the following entry for relative symlink

    %{__ln_s} pbm2l7k $RPM_BUILD_ROOT/%{_bindir}/pbm2lex

Comment 2 Lubomir Kundrak 2007-06-13 21:50:52 UTC
Thanks Marek. You suggestion has been incorporated in the current version of
the package.

Comment 3 Lubomir Kundrak 2007-06-20 20:33:18 UTC
New Package CVS Request
Package Name: pbm2l7k
Short Description: Converts PBM stream to Lexmark 7000, 7200 and 5700 printer
Owners: lkundrak@redhat.com
Branches: FC-6 F-7

Comment 4 Josh Boyer 2007-06-20 20:50:20 UTC
this hasn't been properly reviewed yet.

Comment 5 Marek Mahut 2007-06-28 22:11:10 UTC
+ source files match upstream:
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ license field matches the actual license.
+ license is open source-compatible.  
+ latest version is being packaged.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
+ debuginfo package looks complete.
+ rpmlint is silent.
+ final provides and requires are sane:
  [root@storm pbm2l7k]# rpm -qp --provides
  pbm2l7k = 990321-1.fc8
  [root@storm pbm2l7k]# rpm -qp --requires
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  [root@storm pbm2l7k]# 
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.


Comment 6 Jason Tibbitts 2007-07-01 15:42:55 UTC
CVS done (last night; my connection has been extremely poor lately)

Comment 7 Lubomir Kundrak 2007-07-02 09:48:37 UTC
Thanks Marek and Jason. The package was imported into CVS.

Note You need to log in before you can comment on or make changes to this bug.