Bug 244138 - crash with backtrace because of free
Summary: crash with backtrace because of free
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: gpsbabel
Version: 6
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Roozbeh Pournader
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: bzcl34nup
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-06-14 03:18 UTC by Ronald Kuetemeier
Modified: 2008-05-06 19:41 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-05-06 19:41:29 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
enforce correct free (352 bytes, application/octet-stream)
2007-06-18 20:22 UTC, Ronald Kuetemeier
no flags Details

Description Ronald Kuetemeier 2007-06-14 03:18:36 UTC
Description of problem:
gpsbabel crashes, backtrace.

Version-Release number of selected component (if applicable):
1.3.3-1

How reproducible:
always


Looks like there is  a double free on line  297 and possible 701
(haven't tested it) in garmin.c.  Looks like first free is done via
GPS_WAY_DEL(). Should set pointer to NULL in GPS_WAY_DEL() and test for NULL
before other free().

If you need a patch let me know.

Comment 1 Roozbeh Pournader 2007-06-16 15:55:44 UTC
Apparently it usually happens when the list of things to convert is empty (like
the number of waypoints). This was on my todo list to track and fix, but
apparently I have not found the time yet.

I would appreciate it if you could prepare a patch. It would be much better if
you also send it upstream, of course.

Comment 2 Ronald Kuetemeier 2007-06-18 20:22:13 UTC
Created attachment 157324 [details]
enforce correct free 


I don't know if all the systems gpsbabel runs on use free correctly, so
I just enforce that, otherwise the if could go away. Anyhow I didn't
want to analyze all uses of xfree, so I just enforce correct behavior.

Comment 3 Bug Zapper 2008-04-04 07:24:50 UTC
Fedora apologizes that these issues have not been resolved yet. We're
sorry it's taken so long for your bug to be properly triaged and acted
on. We appreciate the time you took to report this issue and want to
make sure no important bugs slip through the cracks.

If you're currently running a version of Fedora Core between 1 and 6,
please note that Fedora no longer maintains these releases. We strongly
encourage you to upgrade to a current Fedora release. In order to
refocus our efforts as a project we are flagging all of the open bugs
for releases which are no longer maintained and closing them.
http://fedoraproject.org/wiki/LifeCycle/EOL

If this bug is still open against Fedora Core 1 through 6, thirty days
from now, it will be closed 'WONTFIX'. If you can reporduce this bug in
the latest Fedora version, please change to the respective version. If
you are unable to do this, please add a comment to this bug requesting
the change.

Thanks for your help, and we apologize again that we haven't handled
these issues to this point.

The process we are following is outlined here:
http://fedoraproject.org/wiki/BugZappers/F9CleanUp

We will be following the process here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this
doesn't happen again.

And if you'd like to join the bug triage team to help make things
better, check out http://fedoraproject.org/wiki/BugZappers

Comment 4 Bug Zapper 2008-05-06 19:41:28 UTC
This bug is open for a Fedora version that is no longer maintained and
will not be fixed by Fedora. Therefore we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen thus bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.