Spec URL: https://zbyszek.fedorapeople.org/reviews/sso-mib/sso-mib.spec SRPM URL: https://zbyszek.fedorapeople.org/reviews/sso-mib/sso-mib-0.7.0-2.fc45.src.rpm Description: Applications can link with this library to get Entra Conditional Access tokens for authentication and Single-Sign-On from the Himmelblau stack. Fedora Account System Username: zbyszek
Copr build: https://copr.fedorainfracloud.org/coprs/build/10203056 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2445693-sso-mib/fedora-rawhide-x86_64/10203056-sso-mib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correct, license data is correctly installed * Package has no serious issues detected by rpmlint A couple of packaging things to update, though: > %build > %meson > %meson_build Unless you need to support EPEL9 and older, please consider splitting this into %conf and %build sections like so: %conf %meson %build %meson_build > Enhances: git This should be "Enhances: git-core" instead. I'm fine with these being resolved on import, though. PACKAGE APPROVED.
That was quick! Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/sso-mib