Spec URL: https://download.copr.fedorainfracloud.org/results/mcrha/gnome-srpm-macros/srpm-builds/10266405/gnome-srpm-macros.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mcrha/gnome-srpm-macros/srpm-builds/10266405/gnome-srpm-macros-1.0-1.fc45.src.rpm Description: gnome-srpm-macros contains declarations of SRPM macros common to GNOME hosted projects. With these macros being available for the GNOME projects their duplicated declarations can be removed from respective packages. Unlike those current declarations the new macros use LUA instead of shell commands. Fedora Account System Username: mcrha Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/10266425 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2452214-gnome-srpm-macros/fedora-rawhide-x86_64/10266425-gnome-srpm-macros/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I added some safety checks to the macros (to be used only after the Version field is defined), the URL for the package changed (hipefully the next comment will be picked by the automation).
Spec URL: https://download.copr.fedorainfracloud.org/results/mcrha/gnome-srpm-macros_b/srpm-builds/10268808/gnome-srpm-macros.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mcrha/gnome-srpm-macros_b/srpm-builds/10268808/gnome-srpm-macros-1.0-1.fc45.src.rpm Description: gnome-srpm-macros contains declarations of SRPM macros common to GNOME hosted projects. With these macros being available for the GNOME projects their duplicated declarations can be removed from respective packages. Unlike those current declarations the new macros use LUA instead of shell commands. Fedora Account System Username: mcrha
Taking this review.
I think I messed this up when I decided to use COPR for the package upload. I tried to recreate the original project, which re-did the SRPM, but in a new path (as expected), which the package review automation might not notice, I'm afraid. It's at [1] now (and in the URL mentioned in the comment #3 too). Should I close this bug and create a new one to clean up the mess a bit? [1] https://download.copr.fedorainfracloud.org/results/mcrha/gnome-srpm-macros/srpm-builds/10276517/
Can you please include and install a license file? This package says it's GPL-3.0-or-later, but there's no license file to go along with it.
It feels like a waste of everything. I checked some srpm-macros packages do include that (when provided by upstream, I guess), and some not (like those being part of other package). I've been told that the files should have some license, thus I picked the GPL3.0+. I do not mind myself, it could be zlib, LGPL, whatever else, really, the thing is it's a well-known license, Having thousands of copies of it on the system, because thousand of the installed packages use it too, is plain waste of precious disk space and bandwidth. The SPDX is great to save space in the files, because the whole cite of the license "header" can pile up very quickly too. This would be for each and every build of every package in koji (due to to be added Requires into redhat-rpm-config package), where it's plain waste. I mean, I care of the bandwidth and the disk space use. Wasting it by redundant information is not great. If you insist, I can surely add it, but I prefer myself to not do that for the above reasons.
I think MIT would have been perfectly fine for this. But a license does require license text. That's the rule here.
Zlib seemed shorter, thus I picked that one. New place for the files (I'm sorry): Spec URL: https://mcrha.fedorapeople.org/gnome-srpm-macros.spec SRPM URL: https://mcrha.fedorapeople.org/gnome-srpm-macros-1.0-1.fc45.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/10319953 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2452214-gnome-srpm-macros/fedora-rawhide-x86_64/10319953-gnome-srpm-macros/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Review notes: * Package follows Fedora packaging guidelines (trivial package!) * Package builds and installs * Package licensing is correct and license file is installed * No serious issues from rpmlint N.B.: Please reflow the description to wrap at 79 characters on import. PACKAGE APPROVED.
Hrm, the automation did not pick this yet, while I saw it elsewhere to process the import within 20 minutes after approval. Should I ask anywhere what failed? The flags seem to be set correctly to me.
The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-srpm-macros Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
(In reply to Milan Crha from comment #12) > Hrm, the automation did not pick this yet, while I saw it elsewhere to > process the import within 20 minutes after approval. Should I ask anywhere > what failed? The flags seem to be set correctly to me. I failed to follow the process, aka it's my fault. After being notified of that the things move on as they should.