Bug 245527 - Review Request: gdesklets-goodweather - weather and forcast display for gdesklets
Summary: Review Request: gdesklets-goodweather - weather and forcast display for gdesk...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
(Show other bugs)
Version: rawhide
Hardware: All Linux
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2007-06-25 03:48 UTC by Tyler Owen
Modified: 2007-11-30 22:12 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-07-11 01:27:24 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mtasaka: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)
mock build log of gdesklets-goodweather 0.3-1 on rawhide i386 (22.10 KB, text/plain)
2007-07-07 17:54 UTC, Mamoru TASAKA
no flags Details

Description Tyler Owen 2007-06-25 03:48:10 UTC
Spec URL: http://scurn.net/fedora/gdesklets-goodweather.spec
SRPM URL: http://scurn.net/fedora/gdesklets-goodweather-0.3-1.fc7.src.rpm
Themeable weather and condition display for gdesklets. Displays the current
conditions along with a 5 day forcast

There is no license attached with the source tarball, but the README states the code was released under the GPL.

I am currently seeking a sponsor.  

I have also submitted proxychains for review (https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244018)

I have submitted a review for the following packages as well:

Comment 1 Tyler Owen 2007-07-01 15:24:21 UTC
My server that hosts the spec and srpm appears to be down and I am out of town
now so I have mirrored the files on another server that I have access to.


Comment 2 Mamoru TASAKA 2007-07-07 17:54:43 UTC
Created attachment 158722 [details]
mock build log of gdesklets-goodweather 0.3-1 on rawhide i386

Some initial comments
* Mockbuild
  - mockbuild failed on rawhide i386. Note that "python" package is
    removed from minimum build environment (please check the
    log attached)

* Directories
  - The following directories are not owned by any packages.
     *For now* this package should own the directories above.
     (but IMO these directories should be owned by gdesklets.
      Would you contact with gdesklets maintainer?)

* Timestamps
  - To keep timestamps, please use "install -p"

Comment 3 Tyler Owen 2007-07-08 02:24:11 UTC
I have fixed the issues listed above.  

I have also contacted the maintainer of gdesklets and asked them to create/own
the above directories.  In the interim, this package owns the directories.  

* Sat Jul 07 2007 Tyler Owen <tyler.l.owen@gmail.com> - 0.3-2
- Added Python to Requires
- Added -p option to install to preserve timestamps
- Fixed missing directory ownership issues

Spec URL: http://scurn.net/fedora/gdesklets-goodweather.spec
SRPM URL: http://scurn.net/fedora/gdesklets-goodweather-0.3-2.fc7.src.rpm

Comment 4 Mamoru TASAKA 2007-07-08 02:50:53 UTC
http://scurn.net/ still seems no good...

Comment 5 Mamoru TASAKA 2007-07-08 06:17:18 UTC
Well, I downloaded your srpm from other system.
Checking now...

Comment 6 Mamoru TASAKA 2007-07-08 12:42:21 UTC
  For now gdesklets itself does not work on rawhide.
  On Fedora 7, it and this package seem to be working.

  This package (gdesklets-goodweather) is APPROVED by me.

Comment 7 Tyler Owen 2007-07-08 17:24:54 UTC
New Package CVS Request
Package Name: gdesklets-goodweather
Short Description: weather and forcast display for gdesklets
Owners: tyler.l.owen@gmail.com
Branches: F-7

Comment 8 Tyler Owen 2007-07-10 01:05:47 UTC
Package Change Request
Package Name: gdesklets-goodweather
New Branches: FC-6

Comment 9 Kevin Fenzi 2007-07-10 23:08:06 UTC
cvs done.

Comment 10 Tyler Owen 2007-07-11 01:27:24 UTC
Built on devel, F-7 and FC-6
Requested on Bodhi to push.

Thanks for the review and sponsorship!!

Comment 11 Tyler Owen 2007-07-15 19:35:43 UTC
Package Change Request
Package Name: gdesklets-goodweather
Updated Fedora Owners: tyler.l.owen@gmail.com,luya_tfz@thefinalzone.com

Comment 12 Kevin Fenzi 2007-07-16 18:19:31 UTC
cvs done.

Note You need to log in before you can comment on or make changes to this bug.