Spec URL: http://rubenkerkhof.com/packages/perl-Gearman-Server.spec SRPM URL: http://rubenkerkhof.com/packages/perl-Gearman-Server-1.09-1.fc7.src.rpm Description: You run a Gearman server (or more likely, many of them for both high- availability and load balancing), then have workers (using Gearman::Worker from the Gearman module, or libraries for other languages) register their ability to do certain functions to all of them, and then clients (using Gearman::Client, Gearman::Client::Async, etc) request work to be done from one of the Gearman servers. This module needs perl-Gearman, up for review in bug #245655
OK, perl-Gearman is done and I've put it in a local repo so that I can build this. The license problem with perl-Gearman isn't repeated here. Review: * source files match upstream: 472c47d154a7168c627aad97fe04abdb3010275315e26382e13982ec4062a8cd Gearman-Server-1.09.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Gearman::Server) = 1.09 perl(Gearman::Server::Client) perl(Gearman::Server::Job) perl-Gearman-Server = 1.09-1.fc8 = /usr/bin/perl perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Danga::Socket) perl(Danga::Socket) >= 1.52 perl(FindBin) perl(Gearman::Server) perl(Gearman::Server::Client) perl(Gearman::Server::Job) perl(Gearman::Util) perl(Getopt::Long) perl(IO::Socket::INET) perl(POSIX) perl(Scalar::Util) perl(Socket) perl(Sys::Hostname) perl(base) perl(fields) perl(lib) perl(strict) perl(vars) perl(warnings) * %check is present, but there's not actually a test suite to run: No tests defined for Gearman::Server extension. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED
Thanks for the review Jason, New Package CVS Request ======================= Package Name: perl-Gearman-Server Short Description: Function call "router" and load balancer Owners: ruben Branches: FC-6 F-7
I added a BuildRequires for perl-Gearman-Server (which is not in the repo yet) and enabled the tests, and it seems to work in mock. New version: http://rubenkerkhof.com/packages/perl-Gearman-Client-Async.spec http://rubenkerkhof.com/packages/perl-Gearman-Client-Async-0.94-2.fc7.src.rpm
Comment #3 looks like it's in the wrong review request? cvs done. Note again that you should set fedora-cvs to ? and a cvsadmin will set it to + when done.
Package Change Request ====================== Package Name: perl-Gearman-Server New Branches: EL-4 EL-5
cvs done.
Package Change Request ====================== Package Name: perl-Gearman-Server Branches: f15 f14 New InitialCC: perl-sig Please add `perl-sig' to CC list for all Fedora branches as this is Perl package.
This is now done via pkgdb.