Red Hat Bugzilla – Bug 246289
Review Request: atanks - Remake of a classic DOS game "Scorched Earth"
Last modified: 2007-11-30 17:12:08 EST
Spec URL: http://blues.mcgill.ca/~icon/fe/atanks.spec
SRPM URL: http://blues.mcgill.ca/~icon/fe/atanks-2.4-0.1.fc7.src.rpm
Atomic Tanks is a game in which you control an overly-powerful
tank and attempt to blow up other highly powerful tanks. Players
get to select a number of weapons and defensive items and then
attack each other in a turn-based manner. The last tank standing
is the winner.
Cool, nice work.
+ source files match upstream:
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.
+ latest version is being packaged.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
+ debuginfo package looks complete.
+ rpmlint is silent.
+ final provides and requires are sane:
[root@storm atanks]# rpm -qp --provides
atanks = 2.4-0.1.fc8
[root@storm atanks]# rpm -qp --requires
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ desktop file is correct
Everything seems to be correct.
New Package CVS Request
Package Name: atanks
Short Description: Remake of a classic DOS game "Scorched Earth"
Branches: FC-6 F-7
Built -- should show up in f8 and f7-testing in the near future. Thanks, all!
atanks-2.4-1.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report.
atanks-2.4-1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.