Bug 246302 - Review Request: sub2srt - Convert files in .sub format to .srt
Review Request: sub2srt - Convert files in .sub format to .srt
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2007-06-29 17:56 EDT by Marek Mahut
Modified: 2007-11-30 17:12 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-07-14 07:57:36 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Marek Mahut 2007-06-29 17:56:14 EDT
Spec URL: http://people.redhat.com/mmahut/rpms/sub2srt/sub2srt.spec
SRPM URL: http://people.redhat.com/mmahut/rpms/sub2srt/sub2srt-0.5.3-1.fc8.src.rpm
Description: Sub2srt is a simple tool to convert 2 common subtitle
formats (microdvd and subrip - both are known as ".sub")
to subviewer ".srt" format.
Comment 1 Jason Tibbitts 2007-06-29 18:41:15 EDT
There's no reason for the explicit dependency on perl; rpm finds that on its
own.  I don't think it's a blocker, though, merely redundant.

* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   sub2srt = 0.5.3-1.fc8
?  perl (unnecessary)

* %check is not present; no test suite upstream.  It does run OK, though I have 
   no files to test it with.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

Comment 2 Marek Mahut 2007-06-29 19:23:20 EDT
Jason, thank you for your comment and review. I'll remore that dependency once
in CVS.
Comment 3 Marek Mahut 2007-06-29 19:26:25 EDT
New Package CVS Request
Package Name: sub2srt
Short Description: Convert files in .sub format to .srt
Owners: mmahut@redhat.com
Branches: FC-6 F-7 EL-4 EL-5
Comment 4 Kevin Fenzi 2007-07-02 14:42:41 EDT
cvs done.
Comment 5 Jason Tibbitts 2007-07-09 21:19:47 EDT
This doesn't seem to have been built yet.  Is there a problem?
Comment 6 Marek Mahut 2007-07-14 07:57:10 EDT
Sorry for the delay, I was offline.

Package is now build -- thank you Jason for review.

Note You need to log in before you can comment on or make changes to this bug.