Spec URL: http://developer.postgresql.org/~devrim/rpms/other/plruby/postgresql-plruby.spec SRPM URL: http://developer.postgresql.org/~devrim/rpms/other/plruby/postgresql-plruby-0.5.0-1.fc7.src.rpm Description: PL/Ruby is a loadable procedural language for the PostgreSQL database system that enable the Ruby language to create functions and trigger procedures.
Well, as I have some ruby modules packages: Please check the guideline of ruby module packages: http://fedoraproject.org/wiki/Packaging/Ruby Especially: * the name of ruby modules must be ruby-<modules> * the package must have: Requires: ruby(abi) = <version> (and I think the package should have: BuildRequires: ruby(abi) = <version>) * the package must provide ruby(<package>) = <version>-<release> * Usually ruby module packages have Group : Development/Languages For example, I maintain ruby-gettext-package http://cvs.fedoraproject.org/viewcvs/*checkout*/rpms/ruby-gettext-package/devel/ruby-gettext-package.spec More complicated example is ruby-gnome2 (maintained by other people, reviewed by me) http://cvs.fedoraproject.org/viewcvs/*checkout*/rpms/ruby-gnome2/devel/ruby-gnome2.spec
ping?
Hi, (In reply to comment #1) > * the name of ruby modules must be ruby-<modules> This is not a ruby module. This is PL/Ruby for PostgreSQL. So, I am inclined to leave the package name as it is now. > * the package must have: Requires: ruby(abi) = <version> Done. > (and I think the package should have: BuildRequires: ruby(abi) = <version>) Why not ruby-devel ? > * the package must provide ruby(<package>) = <version>-<release> But it does not provide it? > * Usually ruby module packages have Group : Development/Languages As I said, this is a PL for PostgreSQL, so let's leave as Applications/Databases. Thanks for the review. I will post the updated spec and srpm shortly. Regards, Devrim
New spec URL: http://developer.postgresql.org/~devrim/rpms/other/plruby/postgresql-plruby.spec New SRPM URL: http://developer.postgresql.org/~devrim/rpms/other/plruby/postgresql-plruby-0.5.0-1.fc7.src.rpm Regards, Devrim
Sorry for delay. It seems that 0.5.1 is already released. So would you update first?
Hi, I was unavailable for the last few days, and now here is the new set: Spec URL: http://developer.postgresql.org/~devrim/rpms/other/plruby/postgresql-plruby.spec SRPM URL: http://developer.postgresql.org/~devrim/rpms/other/plruby/postgresql-plruby-0.5.1-1.fc7.src.rpm Regards, Devrim
Well, I have not checked your spec/srpm in detail, however * First make sure that your srpm can be rebuilt. http://koji.fedoraproject.org/koji/taskinfo?taskID=185515 - Note: you can try to rebuild arbitrary srpm on koji as $ koji build --scratch <target> <srpm_you_want_to_try> Currently, <target> can be either "dist-f9" "dist-f8" or "dist-fc7-updates-candidate". - Note: ruby-devel requires ruby-libs, but does not require ruby. * Take care of directory ownership issue. All the directories created by this package must be owned by this package. * ruby(abi) version dependency must be with equality, i.e. "Requires: ruby(abi) = 1.8" (like python abi dependency). http://fedoraproject.org/wiki/Packaging/Ruby For consistency, usually I also adds. "BuildRequies: ruby(abi) = 1.8".
I built the new SRPM 5 days ago, but forgot to report here: New spec: http://developer.postgresql.org/~devrim/rpms/other/plruby/postgresql-plruby.spec New SRPM: http://developer.postgresql.org/~devrim/rpms/other/plruby/postgresql-plruby-0.5.1-2.f7.src.rpm Regards, Devrim
Well, would you recheck your srpm so that it can be rebuilt? http://koji.fedoraproject.org/koji/taskinfo?taskID=195921 Some quick notes: * "Requires: postgresql-libs" should usually not needed as rpmbuild checks and adds libraries' dependencies. * %{ruby_sitearch} is owned by ruby-libs so this package should not own this directory * We now recommend %defattr(-,root,root,-)
Hi, (In reply to comment #10) > Well, would you recheck your srpm so that it can be rebuilt? > http://koji.fedoraproject.org/koji/taskinfo?taskID=195921 This is not plruby's problem -- This is a problem of PostgreSQL (AFAICS it cannot be built on ppc, will ping upstream), right? > * %{ruby_sitearch} is owned by ruby-libs so this package should not > own this directory Ok, fixed. > * We now recommend %defattr(-,root,root,-) Ok done. Will upload the new SRPM soon. Regards, Devrim
New spec: http://developer.postgresql.org/~devrim/rpms/other/plruby/postgresql-plruby.spec New SRPM: http://developer.postgresql.org/~devrim/rpms/other/plruby/postgresql-plruby-0.5.1-3.f7.src.rpm Regards, Devrim
I have not checked -3, however (In reply to comment #11) > Hi, > > (In reply to comment #10) > > Well, would you recheck your srpm so that it can be rebuilt? > > http://koji.fedoraproject.org/koji/taskinfo?taskID=195921 > > This is not plruby's problem -- This is a problem of PostgreSQL (AFAICS it > cannot be built on ppc, will ping upstream), right? I doubt it. Rebuild fails even on i386. http://koji.fedoraproject.org/koji/taskinfo?taskID=196241
And please check this comment. (In reply to comment #10) > * "Requires: postgresql-libs" should usually not needed as rpmbuild > checks and adds libraries' dependencies. Also, %defattr is not yet fixed (note: as rebuild fails, I did only quick check and did not review this srpm fully).
Hi, (In reply to comment #14) > And please check this comment. > (In reply to comment #10) > > * "Requires: postgresql-libs" should usually not needed as rpmbuild > > checks and adds libraries' dependencies. I'm inclined to leave it there. > Also, %defattr is not yet fixed It is. Maybe your browser cached the old one. Regards, Devrim
-3 again failed to be rebuilt. http://koji.fedoraproject.org/koji/taskinfo?taskID=197311 Please make it sure that your srpm can be rebuilt. As I said in comment 7, you can check your srpm by koji beforehand whether your srpm can be rebuilt correctly. > > Also, %defattr is not yet fixed > > It is. Maybe your browser cached the old one. Please check %doc subpackage.
ping again?
Once closing. If someone wants to import this package into Fedora, please submit a new review request, thank you.
I don't see any reason to close this bug. You provide no solution as a reviewer -- if you don't want to review this package, leave it as is . Regards, Devrim
(In reply to comment #20) > I don't see any reason to close this bug. Please see "Stalled review" wiki. We close review requests in which the submitters don't response to the last comments from others for more than ONE MONTH (although I usually wait 1 month + 1 week) > You provide no solution as a reviewer -- It is not what the reviewer should resolve, any claims by reviewers must be resolved by the submitter. To make srpm in the shape which can be rebuilt is one of the duty for sumbitters.
Created attachment 290525 [details] proposed spec file The attached spec file does compile. http://koji.fedoraproject.org/koji/taskinfo?taskID=314366 http://koji.fedoraproject.org/koji/taskinfo?taskID=314373 http://koji.fedoraproject.org/koji/taskinfo?taskID=314379
Would you check the spec file attached on comment 22?
Oh yes. Thanks for that -- it works on my test servers, too...
Thanks. I will check this package again later.
Okay. ----------------------------------------------------------------- This package (postgresql-plruby) is APPROVED by me -----------------------------------------------------------------
Would you take a CVS request?
No, not yet. I applied a one line fix to the spec, and I'm testing it on my buildfarm. Will finish soon.
New Spec: http://developer.postgresql.org/~devrim/rpms/other/plruby/postgresql-plruby.spec New SRPM: http://developer.postgresql.org/~devrim/rpms/other/plruby/postgresql-plruby-0.5.1-5.f8.src.rpm
New Package CVS Request ======================= Package Name: postgresql-plruby Short Description: PostgreSQL Ruby Procedural Language Owners: devrim Branches: F-7 F-8 EL-4 EL-5 InitialCC: devrim Cvsextras Commits: no
cvs done. Any reason for the cvsextras commits no? This will make it harder for people to assist you with this package if you aren't available.
I'm always open to co-maintainers -- and this package is not updated frequently, so I don't expect a problem. Mamoru: Thanks for the review and patience. Kevin: Thanks for the CVS. Closing bug.