Red Hat Bugzilla – Bug 246796
Stack overflow detected when running powertop with de_DE.UTF-8 locale
Last modified: 2007-11-30 17:12:09 EST
Description of problem:
When I start powertop with LC_ALL=de_DE.UTF-8, after 5 seconds it says that a
stack overflow has been detected:
The problem seems to be here:
#6 0x0804cf21 in pick_suggestion () at suggestions.c:122
#7 0x0804acfd in main () at powertop.c:649
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. run: LC_ALL=de_DE.UTF-8 powertop
Program terminates with backtrace/stack overflow detection warning (output attached)
A useful screen as it appears with LC_ALL=C
Created attachment 158557 [details]
Backtrace of the error in gdb with powertop-debuginfo installed on F7
1.5 is two releases behind. I'll look at bumping powertop in F-7 to version 1.7
as soon as I can. We'll see if that fixes it.
(In reply to comment #2)
> 1.5 is two releases behind. I'll look at bumping powertop in F-7 to version 1.7
> as soon as I can. We'll see if that fixes it.
I compiled the spec from devel with "make i386" for F-7 and on another machine
there is pretty much the same error, the backtrace only shows another line
number for powertop.c:
#6 0x0804d791 in pick_suggestion () at suggestions.c:122
#7 0x0804ad1d in main () at powertop.c:676
Created attachment 158569 [details]
uses strncpy instead of strcpy for writing into status_bar_slots
This patch fixes at least my issue. The problem is, that just strcpy is used to
write into status_bar_slots, which is 40 characters long. The localized
messages are one character longer. The patch changes all instances of strcpy
into strncpy and also defines constans STATUS_BAR_SLOTSIZE and
STATUS_BAR_NR_SLOTS for usage in strncpy. But I guess the complete source needs
further inspection for similiar bugs. And maybe the SLOTSIZE can be made
bigger, because I guess that some messages may be even longer.
I also sent the patch to power bughost org, but I do not know, whether or not
they accept my mail without being subsribed to the list.
I also found some typos in the german translation, if you want, I add the strcpy
and the translation patch to the devel branch. But I would increase the
STATUS_BAR_SLOTSIZE first, maybe to 60 characters, because there are several
hints, that are longer than 40 characters and would not be displayed completely
Added that patch to 1.7-3.fc8, it'll bubble back to F-7 in an update.
powertop-1.7-3.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report.
powertop-1.7-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.