Bug 2468636 - Update python-types-requests in Rawhide and F44
Summary: Update python-types-requests in Rawhide and F44
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-types-requests
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Michel Lind
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-05-10 14:03 UTC by Adam Williamson
Modified: 2026-05-21 00:56 UTC (History)
7 users (show)

Fixed In Version: python-types-requests-2.32.4.20260107-1.fc45 python-types-requests-2.32.4.20260107-1.fc44
Clone Of:
Environment:
Last Closed: 2026-05-12 21:35:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Adam Williamson 2026-05-10 14:03:40 UTC
Our packaged types-requests is 2.26, which is badly behind our requests version (currently 2.33).

This has one specific issue that annoys me: with current requests it's preferred to import urllib3 stuff (like urllib3.util.retry) directly, not via requests.packages.urllib3 - i.e. you should do:

from urllib3.util.retry import Retry

not:

from requests.packages.urllib3.util.retry import Retry

but our current types-requests does not like this:

[adamw@toolbx fedora-toolbox-44 rmdepcheck (eln-wrapper *)]$ mypy src/rmdepcheck/rdcelwrap.py 
src/rmdepcheck/rdcelwrap.py:191: error: Argument "max_retries" to "HTTPAdapter" has incompatible type "urllib3.util.retry.Retry"; expected "requests.packages.urllib3.util.retry.Retry | int | None"  [arg-type]
Found 1 error in 1 file (checked 1 source file)

I believe this should be fixed in newer types-requests.

Unfortunately updating it to latest is not straightforward because current upstream typeshed requires setuptools >= 82.0.1, which we do not have yet. We could go to a version from before upstream typeshed changed that - I think 2.32.4.20260107 would be the latest we could manage - or we could update setuptools, or I guess we could try and patch typeshed back?

Comment 1 Adam Williamson 2026-05-10 14:11:42 UTC
Confirmed 2.32.4.20260107 builds and fixes the specific issue above. This is the diff, not sending as a PR since it's trivial:

diff --git a/python-types-requests.spec b/python-types-requests.spec
index dfb6a27..4646239 100644
--- a/python-types-requests.spec
+++ b/python-types-requests.spec
@@ -2,13 +2,13 @@
 %global modname types_requests
 
 Name:           python-%{srcname}
-Version:        2.26.1
+Version:        2.32.4.20260107
 Release:        %autorelease
 Summary:        Typing stubs for requests
 # Automatically converted from old format: ASL 2.0 - review is highly recommended.
 License:        Apache-2.0
 URL:            https://github.com/python/typeshed
-Source0:        %{pypi_source %{srcname}}
+Source0:        %{pypi_source %{modname}}
 
 BuildArch:      noarch
 
@@ -33,7 +33,7 @@ Summary:        %{summary}
 
 
 %prep
-%autosetup -p1 -n %{srcname}-%{version}
+%autosetup -p1 -n %{modname}-%{version}

Comment 2 Kevin Fenzi 2026-05-12 21:15:14 UTC
You need rawhide/f44? or ?

Comment 3 Kevin Fenzi 2026-05-12 21:15:28 UTC
Oh duh, it's in the title. ;)

Comment 4 Fedora Update System 2026-05-12 21:30:29 UTC
FEDORA-2026-b32abd93a8 (python-types-requests-2.32.4.20260107-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-b32abd93a8

Comment 5 Fedora Update System 2026-05-12 21:31:23 UTC
FEDORA-2026-1f1d203aa6 (python-types-requests-2.32.4.20260107-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-1f1d203aa6

Comment 6 Fedora Update System 2026-05-12 21:35:14 UTC
FEDORA-2026-b32abd93a8 (python-types-requests-2.32.4.20260107-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Adam Williamson 2026-05-12 22:02:45 UTC
Thanks! But, well, I could have done it myself too - I filed the bug to give the packager a chance to do it rather than just jumping in with pp powers 😅

Also, we could go to 2.33 in Rawhide now, because setuptools has been updated.

Comment 8 Kevin Fenzi 2026-05-12 22:30:09 UTC
Well, I am here via infra-sig... this is a package that was needed/used by the mailman stack... 

sure, I saw that, but hadn't investigated much yet.

Comment 9 Fedora Update System 2026-05-13 23:41:54 UTC
FEDORA-2026-1f1d203aa6 has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-1f1d203aa6`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-1f1d203aa6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2026-05-21 00:56:36 UTC
FEDORA-2026-1f1d203aa6 (python-types-requests-2.32.4.20260107-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.