Description of problem: This is from Ian's report at http://post-office.corp.redhat.com/archives/rhn-satellite/2007-July/msg00034.html In Satellite 5, it seems that it's only possible to specify a file:/// URL for a channel GPG key URL. Any URL that begins with http:// brings up an error message that says: GPG Key URL invalid - please enter a valid URL Is this intended? If so, shouldn't the error message be a little more helpful (not to mention accurate)? Version-Release number of selected component (if applicable): I've verified this on rlx-1-12 running 5.0.0. How reproducible: Deterministic. Also by looking at code. Steps to Reproduce: 1. Go to the Manage Software Channels -> create new channel. 2. Enter mandatory fields, and the GPG key URL value starting with http:// 3. Hit Create Channel. Actual results: Red error message at the top of the form: GPG Key URL invalid - please enter a valid URL Expected results: No error message. Additional info:
Looking at the code, both revisions 108641 and 108646 were incorrect. We probably want to apply the following change: Index: web/modules/sniglets/Sniglets/ChannelEditor.pm =================================================================== --- web/modules/sniglets/Sniglets/ChannelEditor.pm (revision 118117) +++ web/modules/sniglets/Sniglets/ChannelEditor.pm (working copy) @@ -222,7 +222,7 @@ } my $gpg_url = $pxt->dirty_param('channel_gpg_key_url'); - if ($gpg_url ne '' and not $gpg_url =~ m(^(http[s]|file)?\://.*?$)) { + if ($gpg_url ne '' and not $gpg_url =~ m(^(https?|file)\://.*?$)) { $pxt->push_message(local_alert => "GPG Key URL invalid - please enter a valid URL"); $errors++; }
I did not find any such bug in hosted, and in https://engineering.redhat.com/trac/rhn-hosted/browser/hosted/trunk/web/modules/sniglets/Sniglets/ChannelEditor.pm the code is still unfixed. I've now committed the fix to Satellite SVN, trunk revision 118393, branch RELEASE-5.0 revision 118394.
Does this require a release note entry? To me it's iffy because the behavior is supposed to be reported, but then again, it could be considered a new feature :) Let me know either way. Thanks in advance.
Does this require a release note entry? To me it's iffy because the behavior is supposed to be supported, but then again, it could be considered a new feature :) Let me know either way. Thanks in advance.
It really depends what criteria for release notes we have in general. It is a fix of a regression which was reported once internally and once by a customer. If you want a release note, it would be something like: Channel GPG key URL entry now correctly accepts file, http and https protocols.
In my experience, release note entries have been for both major feature releases and big bug fixes. If this is not a major bug fix, I'd leave it out. Clifford, it's your call.
Yes - please add to release notes. From speaking recently with 15 odd Sales Engineers, right now it is 'known' by many that http:// will not work and only https does. Since there was no need to enforce a https:// path to your GPG key file, we should make a small note that this was changed, so folks who do this on a regular basis know. Cliff.
Done. It's in the release notes verbatim from comment #6. Thanks again, Jan.
Moving ON_QA because: Satellite 5.0.1-1 and Proxy 5.0.1-1 are now available on webqa hosted channels. Satellite 5.0.1-1 ISOs are now available.
QA verified that "http://"-prefaced URLs are no longer rejected by the webui.
release pending