Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://omos-fedora-package-reviews.gitlab.io/packages/go-chromecast/srpm/go-chromecast/go-chromecast.spec SRPM URL: https://omos-fedora-package-reviews.gitlab.io/packages/go-chromecast/srpm/go-chromecast/go-chromecast-0.3.4-1.fc45.src.rpm Description: CLI for Google Chromecast, Home devices and Cast Groups. Fedora Account System Username: omos
Copr build: https://copr.fedorainfracloud.org/coprs/build/10520260 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2482667-go-chromecast/srpm-builds/10520260/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Fedora Review Service from comment #1) > Copr build: > https://copr.fedorainfracloud.org/coprs/build/10520260 > (failed) I had access permissions set up incorrectly... Let's try again. [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/10520285 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2482667-go-chromecast/fedora-rawhide-x86_64/10520285-go-chromecast/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec is correct, but ldflags to set version, commit and date are missing. https://github.com/vishen/go-chromecast/blob/master/.goreleaser.yaml#L24 Version and date can be automated, the commit part it's more tricky to automate with Packit so I would be fine if set to "Fedora". One example: https://src.fedoraproject.org/rpms/chezmoi/blob/rawhide/f/chezmoi.spec#_42
Thanks for the review! I haven't yet gotten around to setting up Packit on anything, so I added also the commit info. Updated spec & srpm are at the same URLs: Spec URL: https://omos-fedora-package-reviews.gitlab.io/packages/go-chromecast/srpm/go-chromecast/go-chromecast.spec SRPM URL: https://omos-fedora-package-reviews.gitlab.io/packages/go-chromecast/srpm/go-chromecast/go-chromecast-0.3.4-1.fc45.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/10677903 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2482667-go-chromecast/fedora-rawhide-x86_64/10677903-go-chromecast/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Friendly ping.
thanks for pinging. this is better, but not all ldflags are OK. > export GO_LDFLAGS="-X main.version=%{version} \ > -X main.commit=%{release_commit} \ > -X main.date=$(date -d "@${SOURCE_DATE_EPOCH}" +%Y-%m-%dT%H:%M:%SZ) \ > -X main.builtBy=Fedora" Upstream does the followng: > ldflags: > - -s -w -X main.version={{.Version}} -X main.commit={{.ShortCommit}} -X main.date={{.Date}} Thus the builtBy is not required.
Ok, I think I understand how those flags work now. I dropped the builtBy and kept only those that the package expects. Spec URL: https://omos-fedora-package-reviews.gitlab.io/packages/go-chromecast/srpm/go-chromecast/go-chromecast.spec SRPM URL: https://omos-fedora-package-reviews.gitlab.io/packages/go-chromecast/srpm/go-chromecast/go-chromecast-0.3.4-1.fc45.src.rpm
Created attachment 2148435 [details] The .spec file difference from Copr build 10677903 to 10711194
Copr build: https://copr.fedorainfracloud.org/coprs/build/10711194 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2482667-go-chromecast/fedora-rawhide-x86_64/10711194-go-chromecast/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Golang Package Review ============== This package was generated using go2rpm and Go Vendor Tools, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines. - [x] GO_LDFLAGS are set correctly. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance
The Pagure repository was created at https://src.fedoraproject.org/rpms/go-chromecast Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
(In reply to Mikel Olasagasti Uranga from comment #12) > Package approved! On import, don't forget to do the following: > > - [ ] Add the package to release-monitoring.org https://release-monitoring.org/project/391161/ > - [ ] Give go-sig privileges (at least commit) on the package Done. > - [ ] Close the review bug by referencing its ID in the rpm changelog and > the Bodhi ticket. Should happen soon. > - [ ] Consider configuring Packit service to help with maintenance Maybe in the future :) Thanks a lot!
FEDORA-2026-21f2945f05 (go-chromecast-0.3.4-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-21f2945f05
FEDORA-2026-21f2945f05 (go-chromecast-0.3.4-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.