Red Hat Bugzilla – Bug 248516
Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme
Last modified: 2007-11-30 17:12:10 EST
Spec URL: http://feannatar.hostuju.cz/fedora/files/development/SPECS/nodoka-theme-gnome.spec
SRPM URL: http://feannatar.hostuju.cz/fedora/files/development/SRPMS/nodoka-theme-gnome-0.3.1.1-1.fc7.src.rpm
Description: This package contains the Nodoka theme for Metacity window manager and Nodoka metatheme for Gnome, the metatheme requires gtk-nodoka-engine and echo-icon-theme.
- please use a full source url, if practical
- the emmpty %doc in the file list looks odd, I'd remove that
the description of the main package is a bit misleading:
"The Nodoka Theme Pack for Gnome includes Nodoka Metacity theme, Nodoka gtk2
theme and Echo Icon set."
since it does not actually include these things, but just pull them in
(In reply to comment #1)
> - please use a full source url, if practical
Same as with gtk-nodoka-theme: as we currently use wiki for upstream I think
it's impractical ATM
> - the emmpty %doc in the file list looks odd, I'd remove that
> the description of the main package is a bit misleading:
> "The Nodoka Theme Pack for Gnome includes Nodoka Metacity theme, Nodoka gtk2
> theme and Echo Icon set."
> since it does not actually include these things, but just pull them in
> via dependencies.
Yes, I changed the includes to make use. Seems saner to me...
rpmlint is silent on the produced rpms
package name: ok, I think.
spec name: ok
packaging guidelines: mostly ok
- might be a good idea to put a comment pointing to the wiki location
of the upstream sources
- should add a comment about the "inverse relationship" between main
and subpackage, where the main package requires the subpackage
license field: ok
license file: ok
spec language: ok
spec legibility: ok
upstream sources: ok
build deps: ok
shared libs: n/a
directory ownership: there is a conflict where both the gtk theme package
and the metacity theme package own /usr/share/themes/Nodoka. Possible
solution: make the metacity theme package require the gtk theme package
file list dupes: ok
file permissions: ok
macro use: ok
permissible content: ok
large docs: n/a
%doc content: ok
header files: n/a
static libs: n/a
pc files: n/a
shared lib symlinks: n/a
devel package: n/a
libtool archives: n/a
gui apps: n/a
file ownership: see above
utf8 filenames: ok
I made a new release addressing the above mentioned issues.
Looks fine now. Approved.
New Package CVS Request
Package Name: nodoka-theme-gnome
Short Description: The Nodoka Metacity theme and Gnome metatheme