Red Hat Bugzilla – Bug 249214
Review Request: alienblaster - Action-loaded 2D arcade shooter game
Last modified: 2007-11-30 17:12:11 EST
Spec URL: http://people.atrpms.net/~hdegoede/alienblaster.spec
SRPM URL: http://people.atrpms.net/~hdegoede/alienblaster-1.1.0-1.fc8.src.rpm
Alien Blaster is an action-loaded 2D arcade shooter game. Your mission in the
game is simple: stop the invasion of the aliens by blasting them.
Simultaneous two-player mode is available.
- rpmlint checks return: nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
APPROVED. You're getting rather good at this, Hans. :)
One minor note:
The .sh script you're using to launch the alienblaster.bin has a minor bug
(preventing the game from launching).
Your script make a symlink to "sounds" instead of the correct "sound".
You should fix that before building.
(In reply to comment #2)
> One minor note:
> The .sh script you're using to launch the alienblaster.bin has a minor bug
> (preventing the game from launching).
> Your script make a symlink to "sounds" instead of the correct "sound".
Oopsee, good catch. I noticed this myself too, fixed the symlink in my ~
manually, play tested and then forgot all about it :)
And many thanks for the review!
New Package CVS Request
Package Name: alienblaster
Short Description: Action-loaded 2D arcade shooter game
Branches: FC-6 F-7 devel
imported, build and submitted as F-7 update, closing.