Bug 249524 - Review Request: wxdfast - Multi-threaded download manager
Summary: Review Request: wxdfast - Multi-threaded download manager
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Dan Horák
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2007-07-25 12:16 UTC by Adel Gadllah
Modified: 2007-11-30 22:12 UTC (History)
2 users (show)

Clone Of:
Last Closed: 2007-09-09 09:06:15 UTC
dan: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)
patch for Makefile.* (1.07 KB, patch)
2007-08-22 08:36 UTC, Dan Horák
no flags Details | Diff
spec file patch (820 bytes, patch)
2007-08-22 08:36 UTC, Dan Horák
no flags Details | Diff

Description Adel Gadllah 2007-07-25 12:16:28 UTC
Spec URL: http://tgmweb.at/gadllah/wxdfast.spec
SRPM URL: http://tgmweb.at/gadllah/wxdfast-0.6.0-1.fc7.src.rpm
wxDownload Fast (also known as wxDFast) is an open source multi-threaded
download manager.This means that it can split a file into several pieces
and download the pieces simultaneously

Comment 1 Dan Horák 2007-08-22 07:34:45 UTC
some notes from testing before formal review:
 - update license tag GPL => GPLv2, icons are using Creative Commons Public License
 - in %build - using %configure is enough, no need to set prefix, ..., no need
to explicitly set CXXFLAGS for make
 - remove execute bit from source files (find + xargs chmod a-x)
 - debug package does not contain the sources (tested in mock for Rawhide/i386
and natively on FC6/x86_64)

Comment 2 Dan Horák 2007-08-22 08:35:00 UTC
Sorry, overwriting the CXXFLAGS is necessary. Only in the top-level makefile
they are OK. The debug package is created correctly too. But I have a solution
that can be posted upstream, see attachments.

Comment 3 Dan Horák 2007-08-22 08:36:01 UTC
Created attachment 162036 [details]
patch for Makefile.*

Comment 4 Dan Horák 2007-08-22 08:36:32 UTC
Created attachment 162037 [details]
spec file patch

Comment 5 Adel Gadllah 2007-08-22 09:08:58 UTC
thx for the patches I applied them, new package here:

Comment 6 Dan Horák 2007-08-23 05:50:08 UTC
there is a typo in the spec file when doing chmod a-x - there is \*.cpp twice

Comment 7 Adel Gadllah 2007-08-23 11:35:40 UTC
Fixed package is here:
also some .h files needed fixing added that too.

Comment 8 Dan Horák 2007-08-23 20:18:06 UTC
the review is here:

OK	source files match upstream:
	09f8a13c399e6e8f40e9b0a2776acd4133f0f1f6  wxdfast_0.6.0.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible. License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (Development/i386).
OK	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane:
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	is a GUI app and correctly install its desktop file

this package is APPROVED

PS: are you aware of the many unresolved bugs in the project's sf.net bugtracker?

Comment 9 Adel Gadllah 2007-08-23 21:04:48 UTC
> this package is APPROVED

ok, thx for the review.
> PS: are you aware of the many unresolved bugs in the project's sf.net bugtracker?

no was working quite good for me (no issues yet) but thx will look at them.

Comment 10 Adel Gadllah 2007-08-23 21:07:07 UTC
New Package CVS Request
Package Name: wxdfast
Short Description: Multi-threaded download manager
Owners: drago01
Branches: FC-6 F7 devel
Cvsextras Commits: no

Comment 11 Kevin Fenzi 2007-08-24 15:32:48 UTC
cvs done.

Comment 12 Dan Horák 2007-09-09 09:02:13 UTC
you should close this bug, as the package is already built

Comment 13 Adel Gadllah 2007-09-09 09:06:15 UTC
sorry was waiting for the update push to be able to build it for fc6 then I
forgot to close the bug.

Note You need to log in before you can comment on or make changes to this bug.