Red Hat Bugzilla – Bug 249524
Review Request: wxdfast - Multi-threaded download manager
Last modified: 2007-11-30 17:12:11 EST
Spec URL: http://tgmweb.at/gadllah/wxdfast.spec
SRPM URL: http://tgmweb.at/gadllah/wxdfast-0.6.0-1.fc7.src.rpm
wxDownload Fast (also known as wxDFast) is an open source multi-threaded
download manager.This means that it can split a file into several pieces
and download the pieces simultaneously
some notes from testing before formal review:
- update license tag GPL => GPLv2, icons are using Creative Commons Public License
- in %build - using %configure is enough, no need to set prefix, ..., no need
to explicitly set CXXFLAGS for make
- remove execute bit from source files (find + xargs chmod a-x)
- debug package does not contain the sources (tested in mock for Rawhide/i386
and natively on FC6/x86_64)
Sorry, overwriting the CXXFLAGS is necessary. Only in the top-level makefile
they are OK. The debug package is created correctly too. But I have a solution
that can be posted upstream, see attachments.
Created attachment 162036 [details]
patch for Makefile.*
Created attachment 162037 [details]
spec file patch
thx for the patches I applied them, new package here:
there is a typo in the spec file when doing chmod a-x - there is \*.cpp twice
Fixed package is here:
also some .h files needed fixing added that too.
the review is here:
OK source files match upstream:
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Development/i386).
OK debuginfo package looks complete.
OK rpmlint is silent.
OK final provides and requires look sane:
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK is a GUI app and correctly install its desktop file
this package is APPROVED
PS: are you aware of the many unresolved bugs in the project's sf.net bugtracker?
> this package is APPROVED
ok, thx for the review.
> PS: are you aware of the many unresolved bugs in the project's sf.net bugtracker?
no was working quite good for me (no issues yet) but thx will look at them.
New Package CVS Request
Package Name: wxdfast
Short Description: Multi-threaded download manager
Branches: FC-6 F7 devel
Cvsextras Commits: no
you should close this bug, as the package is already built
sorry was waiting for the update push to be able to build it for fc6 then I
forgot to close the bug.