Description of problem: Missing BuildReq: automake in spec file Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. Try to rebuild the SRPM on a clean system (e.g. mock) 2. 3. Actual results: Fails to build Expected results: Builds Additional info: Attached patch fixes this
Created attachment 160314 [details] Fixes spec file
Does CUPS really use automake? Please attach a failed build log showing the error.
Created attachment 160318 [details] Build log showing failed cups build without automake package installed
Line 172 of the spec file calls aclocal, which is in the automake package
Ah, I see. The correct fix is to remove that line. It was added in error in 2004.
It seems autoconf is needed, otherwise compilation fails with the following error: Making all in cups... make[1]: Entering directory `/builddir/build/BUILD/cups-1.1.22rc1/cups' echo Compiling attr.c... Compiling attr.c... gcc -fPIC -O2 -g -pipe -m32 -march=i386 -mtune=pentium4 -I/usr/kerberos/include -DOPENSSL_DISABLE_OLD_DES_SUPPORT -I/usr/kerberos/include -I/usr/kerberos/ include -I.. @LARGEFILE@ -fpic -c attr.c gcc: @LARGEFILE@: No such file or directory In file included from attr.c:38: /usr/include/stdlib.h:209: error: syntax error before '(' token /usr/include/stdlib.h:209: error: conflicting types for 'strtol' /usr/include/stdlib.h:185: error: previous declaration of 'strtol' was here /usr/include/stdlib.h:209: error: conflicting types for 'strtol' /usr/include/stdlib.h:185: error: previous declaration of 'strtol' was here /usr/include/stdlib.h:209: error: syntax error before "char" /usr/include/stdlib.h:332: error: conflicting types for 'strtol' /usr/include/stdlib.h:209: error: previous declaration of 'strtol' was here /usr/include/stdlib.h:332: error: conflicting types for 'strtol' /usr/include/stdlib.h:209: error: previous declaration of 'strtol' was here /usr/include/stdlib.h:376: error: syntax error before '(' token /usr/include/stdlib.h:376: error: conflicting types for 'strtol' /usr/include/stdlib.h:332: error: previous definition of 'strtol' was here /usr/include/stdlib.h:376: error: conflicting types for 'strtol' /usr/include/stdlib.h:332: error: previous definition of 'strtol' was here /usr/include/stdlib.h:376: error: syntax error before "char" make[1]: *** [attr.o] Error 1 make[1]: Leaving directory `/builddir/build/BUILD/cups-1.1.22rc1/cups' make: *** [all] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.32492 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.32492 (%build) It seems that @LARGEFILE@ needs to be replaced somewhere and isn't. So, I've updated the summary to reflect that autoconf needs to be included in BuildReq in order for cups to build cleanly in a clean environment like mock.
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2008-0669.html