Red Hat Bugzilla – Bug 250893
Review Request: audio-convert-mod - A simple audio file converter supporting many formats
Last modified: 2007-11-30 17:12:12 EST
Spec URL: http://www.diffingo.com/downloads/audio-convert-mod/audio-convert-mod.spec
SRPM URL: http://www.diffingo.com/downloads/audio-convert-mod/audio-convert-mod-3.45.0-1.fc7.src.rpm
Description: audio-convert-mod is a simple audio file converter supporting various formats via external binaries. It facilitates the batch conversion of audio files from one format to another by access from the menu or by the user script where at a right-click files can be converted at once. It also supports file tags/metadata where applicable.
rpmlint is silent on the source and binary rpms.
License: GPL is not sufficient, you have to specify which one, as per
I notice source files specifying GPL 2 or later.
You have your python macro backwards: get_python_lib(1) is how the sitearch
macro is defined. Really it should be get_python_lib() for a noarch. However, in
the Makefile, it expands $(LIBDIR). I suggest fixing this to use python to PYMODDIR.
There is an uninstall script. Remove, rpm is going to manage this.
Does not use restricted code, rather calls programs if they exist. Good.
I've made a new new release 3.45.1 (fixes the Makefiles) and adds a few new
features. In terms of the spec, I reverted to sitelib rather than sitearch.
rpmlint is still silent on both.
+ follows python template
+ name version release good
+ license (GPLv2+)
+ source matches upstream
+ builds on x86_64
+ rpmlint clean
+ %clean section
+ .desktop file
New Package CVS Request
Package Name: audio-convert-mod
Short Description: A simple audio file converter supporting many formats
Branches: FC-6 F-7
Cvsextras Commits: no
Forgot to set the flag...
Built - Thanks
audio-convert-mod-3.45.1-1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.