Bug 250924 - Review Request: flashrom - Simple program for reading/writing BIOS chips content
Summary: Review Request: flashrom - Simple program for reading/writing BIOS chips content
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All Linux
medium
medium
Target Milestone: ---
Assignee: Till Maas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-08-05 11:46 UTC by Peter Lemenkov
Modified: 2007-11-30 22:12 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-10-01 04:53:13 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
opensource: fedora-review+
petersen: fedora-cvs+


Attachments (Terms of Use)

Description Peter Lemenkov 2007-08-05 11:46:49 UTC
Spec URL: http://peter.fedorapeople.org/flashrom.spec
SRPM URL: http://peter.fedorapeople.org/flashrom-0.0-1.2742svn.fc7.src.rpm
Description: Utility which can be used to detect BIOS chips (DIP, PLCC), read their contents and write new contents on the chips ("flash the chip").



All of you, no doubt, heard something about LinuxBIOS project which has slow but constant progress in providing completely open startup-firmware (also known as BIOS) for a not so little number of mainboards (from desktop ones to more specific). 

Since the project continues to rise there are some utilities appears which may be useful even for users of proprietary BIOSes. One of such utilities is flashrom - it helps (re)flashing firmware w/o needs to create LiveCDs powered with my grandma's 8-bit DOS and rebooting to it.

See some user cases at the link below:

http://www.hermann-uwe.de/blog/flashing-a-bios-the-linux-way-tm-using-flashrom

I've got some thing to discuss - versioning of this package. Upstream still haven't any version (just svn revision) so I decided to name it as flashrom-0.0-1.2742svn.fc7 but maybe it would be better to name it like flashrom-0-1.2742svn.fc7 or something similar?

Comment 1 Peter Lemenkov 2007-08-22 12:59:08 UTC
minor update - svn  2744 where added support for EPoX EP-BX3 board.

http://peter.fedorapeople.org/flashrom.spec
http://peter.fedorapeople.org/flashrom-0.0-1.2744svn.fc7.src.rpm

Comment 2 Till Maas 2007-09-06 14:30:34 UTC
This seems to be a pre release snaphsot, so the release should start with 0.
Also you can use 0 for the Version instead of 0.0. So here is my proposal:
Version: 0
Release: 0.1.<date>svn2744%{?dist}

You should also include the date of the checkout, see:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages
If the checkouts you want to package are normally more than a day old, you can
also use the date to specify which version you want to checkout, e.g.
svn -r "{20070901}" export svn://linuxbios.org/repos/trunk/util/flashrom flashrom
Then you do not need to carry the svn revision.

Hint:
# svn -r 2744 co svn://linuxbios.org/repos/trunk/util/flashrom flashrom
# rm -rf flashrom/.svn
you can use svn export instead of co to avoid the creation of the .svn directory.

You should use
install -D -p -m644 %{name}.1 $RPM_BUILD_ROOT%{_mandir}/man1/%{name}.1
to install the manpage (-p is added here) to preserve the timestamp.

Comment 3 Peter Lemenkov 2007-09-06 15:01:00 UTC
(In reply to comment #2)
> This seems to be a pre release snaphsot, so the release should start with 0.
> Also you can use 0 for the Version instead of 0.0. So here is my proposal:
> Version: 0
> Release: 0.1.<date>svn2744%{?dist}
> You should also include the date of the checkout...

Done.

> # svn -r 2744 co svn://linuxbios.org/repos/trunk/util/flashrom flashrom
> # rm -rf flashrom/.svn
> you can use svn export instead of co to avoid the creation of the .svn directory.

Applied, thanks. 
Until now I never heard about such option :)

> You should use
> install -D -p -m644 %{name}.1 $RPM_BUILD_ROOT%{_mandir}/man1/%{name}.1
> to install the manpage (-p is added here) to preserve the timestamp.

Done.

http://peter.fedorapeople.org/flashrom.spec
http://peter.fedorapeople.org/flashrom-0-0.1.20070830svn2753.fc7.src.rpm



Comment 4 Till Maas 2007-09-06 15:50:06 UTC
rpmlint: ok (silent)
naming: ok (no upstream versioning, yet, version 0 should not conflict with any
version)
license: ok (GPLv2+, license text not included, but refered to in source files)
spec legible: ok
source0: svn checkout, instructions included, tarball matches own export: ok
ExcludeArch: ppc, ppc64: bugs need to be filed against FE-ExcludeArch-ppc,
FE-ExcludeArch-ppc64 once the package is imported
BuildRequires: ok, builds in mock for i386, F7
no library / devel stuff: ok
directory ownage: ok
%files section: no duplicates, defattr specified:ok
rm -rf %{buildroot} in %install and %clean: ok
%changelog format: ok

APPROVED, don't forget to file bugs against the Excludearch blocker bugs.


Optional:
Can you ask upstream to add an license header to udelay.c and include a copy of
their license in the repository?

There are some build warnings that should be reported upstream:
layout.c: In function 'read_romlayout':                                        
                                                                           
layout.c:114: warning: ignoring return value of 'fscanf', declared with
attribute warn_unused_result 
flashrom.c: In function 'main':                                                
                                                                           
flashrom.c:402: warning: ignoring return value of 'fwrite', declared with
attribute warn_unused_result                                                   
  flashrom.c:421: warning: ignoring return value of 'fread', declared with
attribute warn_unused_result 

Comment 5 Peter Lemenkov 2007-09-07 08:20:00 UTC
OK, thanks.
But I still can't checkout such module:

[petro@Sulaco FE]$ cvs co flashrom
cvs server: cannot find module `flashrom' - ignored
cvs [checkout aborted]: cannot expand modules
[petro@Sulaco FE]$


Comment 6 Till Maas 2007-09-07 09:02:18 UTC
You need to follow this
http://fedoraproject.org/wiki/PackageMaintainers/NewPackageProcess
You are at step 8 now.

Comment 7 Peter Lemenkov 2007-09-07 09:56:51 UTC
New Package CVS Request
=======================
Package Name: flashrom
Short Description: Simple program for reading/writing BIOS chips content
Owners: peter
Branches: FC-6 F-7
InitialCC: 
Cvsextras Commits: yes

Comment 8 Kevin Fenzi 2007-09-07 18:29:12 UTC
cvs done.

Comment 9 Peter Lemenkov 2007-09-30 18:23:43 UTC
Package Change Request
======================
Package Name: flashrom
New Branches: EL-4 EL-5

Comment 10 Jens Petersen 2007-10-01 04:38:33 UTC
added


Note You need to log in before you can comment on or make changes to this bug.