Red Hat Bugzilla – Bug 251536
Review Request: xorg-x11-drv-diamondtouch - Xorg diamondtouch input driver
Last modified: 2008-02-21 13:53:20 EST
Spec URL: http://people.fedoraproject.org/~ajax/diamondtouch/xorg-x11-drv-diamondtouch.spec
SRPM URL: http://people.fedoraproject.org/~ajax/diamondtouch/xorg-x11-drv-diamondtouch-0.2.0-0.1.fc8.src.rpm
The MERL Diamondtouch is a multi-user touchscreen. See demo video:
This is the X driver for same.
I'd be happy to review this package, although I don't have the hardware.
Look for a full review in a bit.
This package doesn't seem to build for me under devel mock:
gcc -DHAVE_CONFIG_H -I. -I. -I.. -Wall -I../include -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4
-m64 -mtune=generic -I/usr/include/xorg -I../src -MT
diamondtouch_drv_la-diamondtouch.lo -MD -MP -MF
.deps/diamondtouch_drv_la-diamondtouch.Tpo -c diamondtouch.c -fPIC -DPIC -o
diamondtouch.c: In function 'DtReadInput':
diamondtouch.c:417: warning: implicit declaration of function 'xf86DisableDevice'
diamondtouch.c: In function '_dt_init_axes':
diamondtouch.c:698: error: 'GetMotionHistory' undeclared (first use in this
diamondtouch.c:698: error: (Each undeclared identifier is reported only once
diamondtouch.c:698: error: for each function it appears in.)
diamondtouch.c:699: warning: implicit declaration of function 'GetMotionHistorySize'
diamondtouch.c:704: warning: implicit declaration of function
make: *** [diamondtouch_drv_la-diamondtouch.lo] Error 1
make: Leaving directory `/builddir/build/BUILD/xf86-input-diamondtouch-0.2.0/src'
make: *** [all-recursive] Error 1
make: Leaving directory `/builddir/build/BUILD/xf86-input-diamondtouch-0.2.0'
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.91130 (%build)
Missing BuildRequires? Or something else going on?
Mmm. Might require either MPX branch of X, or else new input stuff that'll be
in 1.4, and it only built for me because I had sdk pollution.
Feel free to ignore this for a while.
Any further news on this?
This builds with the xorg-x11-server-devel in rawhide now.
I of course don't have the hardware to test this, but
I can check the package otherwise.
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (MIT)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
See below - Headers/static libs in -devel subpackage.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane.
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version
1. Might ask upstream to include a copy of the license they use.
Not a blocker of course.
2. rpmlint complains:
xorg-x11-drv-diamondtouch.x86_64: W: devel-file-in-non-devel-package
Is there any point in shipping this header file?
I'll leave it up to you if you want to ship that header or not,
otherwise this package is APPROVED.
Yeah, the header probably shouldn't ship, I can't think of a reason for
New Package CVS Request
Package Name: xorg-x11-drv-diamondtouch
Short Description: Xorg diamondtouch input driver
Cvsextras Commits: yes
Built in rawhide, thanks!