Spec URL: http://rubenkerkhof.com/packages/perl-Perlbal-XS-HTTPHeaders.spec SRPM URL: http://rubenkerkhof.com/packages/perl-Perlbal-XS-HTTPHeaders-0.19-1.fc7.src.rpm Description: This module is used to read HTTP headers from a string and to parse them into an internal storage format for easy access and modification. You can also ask the module to reconstitute the headers into one big string, useful if you're writing a proxy and need to read and write headers while maintaining the ability to modify individual parts of the whole.
change License tag to GPL+ or Artistic
good to have t/* added under %doc
> change License tag to GPL+ or Artistic Actually, there's no license information in the tarball. I asked upstream for clarification > good to have t/* added under %doc What are the advantages of doing that? make check already runs on the buildservers, and adding tests to doc is not a very common thing to do for perl packages
(In reply to comment #3) > > change License tag to GPL+ or Artistic > > Actually, there's no license information in the tarball. Wrong. As with most perl-dists, it's inlined into the source code: http://search.cpan.org/~marksmith/Perlbal-XS-HTTPHeaders-0.19/lib/Perlbal/XS/HTTPHeaders.pm#COPYRIGHT_AND_LICENSE
Sorry, your right, missed that. New version: http://rubenkerkhof.com/packages/perl-Perlbal-XS-HTTPHeaders-0.19-2.fc7.src.rpm
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url d011eeda6adedf069620e11e6d701b77 Perlbal-XS-HTTPHeaders-0.19.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/HTTPHeaders....ok All tests successful. Files=1, Tests=31, 0 wallclock secs ( 0.19 cusr + 0.02 csys = 0.21 CPU) + exit 0 + Provides: HTTPHeaders.so perl(Perlbal::XS::HTTPHeaders) = 0.19 + Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) perl >= 0:5.008 perl(:MODULE_COMPAT_5.8.8) perl(AutoLoader) perl(Carp) perl(Exporter) perl(Perlbal) perl(Perlbal::HTTPHeaders) perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH) APPROVED.
Thanks Parag New Package CVS Request ======================= Package Name: perl-Perlbal-XS-HTTPHeaders Short Description: Perlbal extension for processing HTTP Headers Owners: ruben Branches: FC-6 F-7 EL-4 EL-5
Oops, wrong flag New Package CVS Request ======================= Package Name: perl-Perlbal-XS-HTTPHeaders Short Description: Perlbal extension for processing HTTP Headers Owners: ruben Branches: FC-6 F-7 EL-4 EL-5
Package Change Request ====================== Package Name: perl-Perlbal-XS-HTTPHeaders Branches: f15 f14 New InitialCC: perl-sig Please add `perl-sig' to CC list for all Fedora branches as this is Perl package.
This is now done via pkgdb.