Bug 253144 - RFE: confirmation before deleting guest
Summary: RFE: confirmation before deleting guest
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: virt-manager
Version: 5.1
Hardware: All
OS: Linux
Target Milestone: ---
: ---
Assignee: Cole Robinson
QA Contact: Virtualization Bugs
Keywords: EasyFix, Patch
Depends On:
TreeView+ depends on / blocked
Reported: 2007-08-17 05:39 UTC by David Robinson
Modified: 2009-12-14 21:17 UTC (History)
2 users (show)

Clone Of:
Last Closed: 2008-05-21 17:28:23 UTC

Attachments (Terms of Use)
ask user for confirmation (1.04 KB, patch)
2007-08-20 05:33 UTC, David Robinson
no flags Details | Diff

External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2008:0480 normal SHIPPED_LIVE virt-manager bug fix and enhancement update 2008-05-20 13:36:50 UTC

Description David Robinson 2007-08-17 05:39:57 UTC
Description of problem:
Now that shutdown guests are shown in virt-manager they can be deleted, however
there is no confirmation dialog box when pressing the Delete button. It would be
a good idea (TM) to ask for confirmation when deleting guests, especially
considering that the Delete button is right next to the New button.

When removing files, as root, from the command line you are asked for
confirmation. IMHO its easier to accidentally click Delete and wipe away an
entire guest than to accidentally type the wrong filename, yet you are protected
from the more unlikely scenario (does that make sense?)

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. accidentally press the Delete button
Actual results:

Expected results:
opps, phew!

Comment 1 David Robinson 2007-08-20 05:33:15 UTC
Created attachment 161843 [details]
ask user for confirmation

Comment 2 Cole Robinson 2007-11-06 15:43:41 UTC
This is already upstream, though coupled with serious UI overhaul. So if the
upstream changes aren't pulled in, the reporter provided a non-intrusive patch
that can definitely be used. Recommended for RHEL 5.2

Comment 3 RHEL Product and Program Management 2007-11-06 15:44:34 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update

Comment 4 Cole Robinson 2008-01-17 17:56:08 UTC
We've rebased to virt-manager 0.5.3, which contains the fix for this bug:

Build                                     Tag                   Built by
----------------------------------------  --------------------  ----------------
virt-manager-0.5.3-1.el5                  dist-5E-qu-candidate  berrange

Attempting to delete a guest brings up confirmation dialog, pretty straight
forward to verify.

Comment 8 errata-xmlrpc 2008-05-21 17:28:23 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.