Bug 253597 - Wrong colours connecting to OSX server
Summary: Wrong colours connecting to OSX server
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: gtk-vnc
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Daniel Berrangé
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-08-20 19:03 UTC by Bastien Nocera
Modified: 2007-11-30 22:12 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-08-22 23:44:36 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)
Screenshot.png (704.95 KB, image/png)
2007-08-20 19:03 UTC, Bastien Nocera 		no flags Details
Fix endianness handling, and BGR pixel formats (4.53 KB, patch)
2007-08-22 16:10 UTC, Daniel Berrangé 		no flags Details | Diff
Fix endianness handling, and BGR pixel formats (4.36 KB, patch)
2007-08-22 16:19 UTC, Daniel Berrangé 		no flags Details | Diff
Show Obsolete (1) View All

Description Bastien Nocera 2007-08-20 19:03:51 UTC 
gtk-vnc-0.1.0-3.fc8 on x86_64
OXSVNC 1.71 on MacOS X 10.4.10 (iirc)

The colours are wrong (as per screenshot). The background is supposed to be blue.
Comment 1 Bastien Nocera 2007-08-20 19:03:54 UTC 
Created attachment 161913 [details]
Screenshot.png
Comment 2 Daniel Berrangé 2007-08-22 16:10:54 UTC 
Created attachment 162073 [details]
Fix endianness handling, and BGR pixel formats

The attached patch should fix GTK-VNC's handling of endianness differences
between client & server by reversing the pixel shifts. It also fixes handling
of BGR pixel formats by removing some redundant & wrong logic.
Comment 3 Bastien Nocera 2007-08-22 16:14:41 UTC 
Comment on attachment 162073 [details]
Fix endianness handling, and BGR pixel formats

<snip>
>-#define DEBUG 0
>+#define DEBUG 1

Is debug supposed to be left on?
Comment 4 Daniel Berrangé 2007-08-22 16:19:56 UTC 
Created attachment 162075 [details]
Fix endianness handling, and BGR pixel formats

No DEBUG wasn't supposed to be left on.
Comment 5 Daniel Berrangé 2007-08-22 22:50:25 UTC 
Committed to CVS, build pending....

* Wed Aug 22 2007 Daniel P. Berrange <berrange> - 0.1.0-4.fc8
- Fix mixed endian handling & BGR pixel format (rhbz #253597)
- Clear widget areas outside of framebuffer (rhbz #253599)
- Fix off-by-one in python demo
Comment 6 Daniel Berrangé 2007-08-22 23:44:36 UTC 
Build complete, in rawhide.
Note You need to log in before you can comment on or make changes to this bug.